Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVS3 Video according to T/AI 109.2 #2183

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

paulhiggs
Copy link

No description provided.

@JeromeMartinez
Copy link
Member

Sorry I forgot about this PR.
Please a sample file so I can check how it behaves.

@paulhiggs
Copy link
Author

There are an assortment of differently coded AVS3 Video bitstreams in the DVB V&V catalog - https://dvb.org/specifications/verification-validation/avs3-test-content/

Copy link
Contributor

@cjee21 cjee21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting alignment issues that I happen to notice, some of which are caused by the presence of tab characters.

@@ -578,6 +579,7 @@ static File__Analyze* SelectFromExtension(const String& Parser)
#endif
#if defined(MEDIAINFO_AVSV_YES)
if (Parser==__T("AvsV")) return new File_AvsV();
if (Parser==__T("Avs3V")) return new File_Avs3V();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (Parser==__T("Avs3V")) return new File_Avs3V();
if (Parser==__T("Avs3V")) return new File_Avs3V();

Comment on lines +51 to +61
#define Patch_Start_Code(sc) ((sc)>=0x00 && (sc)<=0x7F)
#define Patch_End_Code 0x8F
#define Video_Sequence_Start_Code 0xB0
#define Video_Sequence_End_Code 0xB1
#define User_Data_Start_Code 0xB2
#define Intra_Picture_Start_Code 0xB3
#define Avs3_Reserved1 0xB4
#define Extension_Start_Code 0xB5
#define Inter_Picture_Start_Code 0xB6
#define Video_Edit_Code 0xB7
#define Avs3_Reserved2 0xB8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define Patch_Start_Code(sc) ((sc)>=0x00 && (sc)<=0x7F)
#define Patch_End_Code 0x8F
#define Video_Sequence_Start_Code 0xB0
#define Video_Sequence_End_Code 0xB1
#define User_Data_Start_Code 0xB2
#define Intra_Picture_Start_Code 0xB3
#define Avs3_Reserved1 0xB4
#define Extension_Start_Code 0xB5
#define Inter_Picture_Start_Code 0xB6
#define Video_Edit_Code 0xB7
#define Avs3_Reserved2 0xB8
#define Patch_Start_Code(sc) ((sc)>=0x00 && (sc)<=0x7F)
#define Patch_End_Code 0x8F
#define Video_Sequence_Start_Code 0xB0
#define Video_Sequence_End_Code 0xB1
#define User_Data_Start_Code 0xB2
#define Intra_Picture_Start_Code 0xB3
#define Avs3_Reserved1 0xB4
#define Extension_Start_Code 0xB5
#define Inter_Picture_Start_Code 0xB6
#define Video_Edit_Code 0xB7
#define Avs3_Reserved2 0xB8

@JeromeMartinez
Copy link
Member

Just some formatting alignment issues that I happen to notice, some of which are caused by the presence of tab characters.

I'll fix that during review/updates.

@cjee21
Copy link
Contributor

cjee21 commented Feb 12, 2025

There are some AVS3 in MKV files here: https://github.com/xatabhk/avs2-avs3-video-samples

@JeromeMartinez
Copy link
Member

There are some AVS3 in MKV files here

Thank you, I added them to my test repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants