Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7941] Test Case Validation: Demote Terminology Errors to Warnings #267

Merged

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Nov 26, 2024

MADiE FHIR SERVICE

Jira Ticket: MAT-7941
(Optional) Related Tickets:

Summary

Accept the result of the In Memory Validator and demote any Error findings to Warning.

The In Memory validator is unable to expand the internal US-Core value sets (because they now point to VSAC instead of being a static list of codes) and concludes codes used in test cases are invalid.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner November 26, 2024 20:55
@jkotanchik-SB jkotanchik-SB self-assigned this Nov 26, 2024
…dation for QI-Core 6 only by replacing the In Memory Terminology validator with our custom lenient validator, composed of the In Memory validator.

The In Memory validator is unable to expand the internal US-Core value sets (because they now point to VSAC instead of being a static list of codes) and concludes codes used in test cases are invalid.

Accept the result of the In Memory Validator and demote any Error findings to Warning.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7941-lenient-terminology-validation-qicore6 branch from edebadf to 118da42 Compare November 26, 2024 21:12
@jkotanchik-SB jkotanchik-SB merged commit dcc574a into develop Nov 27, 2024
6 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7941-lenient-terminology-validation-qicore6 branch November 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants