Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7570: Limit the date shift year result range to [1900, 9999] #239

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Aug 28, 2024

MADiE FHIR SERVICE

Jira Ticket: MAT-7570
(Optional) Related Tickets:

Summary

Limit the Date Shift year result range to [1900, 9999].

Also remembered to commit the formatter updates 👍

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

Sorry, something went wrong.

@jkotanchik-SB jkotanchik-SB requested a review from a team as a code owner August 28, 2024 20:16
@jkotanchik-SB jkotanchik-SB self-assigned this Aug 28, 2024
@jkotanchik-SB jkotanchik-SB changed the title MAT-7570: Limit the date shift year result range to [1,9999]. MAT-7570: Limit the date shift year result range to [1900, 9999] Aug 29, 2024
adongare
adongare previously approved these changes Aug 30, 2024
    The FHIR models use the older java.util.Date class to back the FHIR Date and DateTime values. Java Date does not support a year 0 (as it does not exist in the Gregorian calendar), hence the QICore Date Shift range min must be 1.
@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7570-limit-date-shift-year-range branch from 05505d8 to 9ce4020 Compare August 30, 2024 18:12
@jkotanchik-SB jkotanchik-SB merged commit eb0c129 into develop Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants