Updating types to match Polykey#846 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot that working on an 'unreleased' polykey version will cause test failures. Oops. |
aryanjassal
force-pushed
the
feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation
branch
from
b61c9bf to
4415fbb
Compare
tegefaulkes
requested changes
Jan 29, 2025
aryanjassal
force-pushed
the
feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation
branch
from
427b0cd to
dd3bea9
Compare
chore: streaming secret to file deps: updated polykey to 1.17.4 fix: cleaned up secrets edit command chore: enforced runtime type safety for some secrets commands
aryanjassal
force-pushed
the
feature-eng-432-review-and-refactor-rpc-handlers-to-handle-cancellation
branch
from
3b14472 to
720eff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There have been a lot of changes in MatrixAI/Polykey#846 which require changes in Polykey CLI too. This PR makes those changes, ensuring the CLI remains up to date.
Issues Fixed
Tasks
VaultsSecretsGetto prepare for its removalFinal checklist