adapter/storage: Cast MySQL bit columns to uint8, add convience functions
#31097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
force-pushed
the
mysql/bit-type
branch
from
677e43e to
f994fae
Compare
jkosh44
approved these changes
Jan 17, 2025
src/adapter/BUILD.bazel
Outdated
| @@ -24,7 +24,6 @@ rust_library( | |||
| compile_data = [], | |||
| crate_features = ["default"], | |||
| data = [], | |||
| disable_pipelining = True, | |||
There was a problem hiding this comment.
Did you mean to include this in this PR? It seems a bit unrelated.
There was a problem hiding this comment.
I didn't was rebased on the wrong branch by accident, removed!
| .get(byte_index) | ||
| .map(|b| (*b >> bit_index) & 1) | ||
| .ok_or(err)?; | ||
| Ok(Datum::from(i32::from(i))) |
There was a problem hiding this comment.
If I'm understanding correctly, the following might be useful: assert!(i == 0 || i == 1)
Good idea, I'll add them in a separate PR though so we can merge them when v0.131 goes out |
ParkMyCar
force-pushed
the
mysql/bit-type
branch
from
f2485a9 to
67c8301
Compare
ParkMyCar
changed the title
bit columns to bytea, add convience functionsbit columns to uint8, add convience functions
ParkMyCar
force-pushed
the
mysql/bit-type
branch
from
67c8301 to
e6b3ef2
Compare
ParkMyCar
force-pushed
the
mysql/bit-type
branch
from
e6b3ef2 to
99fad97
Compare
def-
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Thanks for adding tests!
Edit: I added platform checks scenario, green nightly run with it: https://buildkite.com/materialize/nightly/builds/10923
ggevay
pushed a commit
that referenced
this pull request
Jan 21, 2025
…unctions (#31097) This PR changes the MySQL source to support ingesting the `bit` type as `uint8`. It also adds two new Postgres functions, `bit_count(bytea)` and `get_bit(bytea, int32)` to making working with byte strings easier. ### Motivation Progress towards: MaterializeInc/database-issues#8891 ### Checklist - [x] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [x] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [x] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [x] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [x] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post. --------- Co-authored-by: Dennis Felsing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the MySQL source to support ingesting the
bittype asuint8. It also adds two new Postgres functions,bit_count(bytea)andget_bit(bytea, int32)to making working with byte strings easier.Motivation
Progress towards: https://github.com/MaterializeInc/database-issues/issues/8891
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.