Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the QUALIFY keyword, which is a new reserved keyword. We should quickly add this now, before the first self-managed release is cut, because now we still can check that no user would get in conflict with the new reserved keyword by checking all cloud usage.
Discussed on Slack here and here.
I'm running a Snowflake query to check for occurrences right now, because of the reservedness of the keyword, see Slack discussions. (I checked it once 3 months ago, but checking again now.) Edit: Done. The new Snowflake query also didn't turn up any conflicts for either
QUALIFY
orWINDOW
.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.