Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: actually treat CREATE TABLE ... FROM WEBHOOK as a Table #31001

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ParkMyCar
Copy link
Member

@ParkMyCar ParkMyCar commented Jan 10, 2025

Some refactoring in the Adapter to treat objects created by CREATE TABLE ... FROM WEBHOOK actually as tables. This way they show up when querying mz_tables, you can run SHOW CREATE TABLE ..., etc.

Motivation

Fixes https://github.com/MaterializeInc/database-issues/issues/8862

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar force-pushed the webhook/create-table-fixes branch 2 times, most recently from 3678c6a to f205d1b Compare January 13, 2025 15:02
@ParkMyCar ParkMyCar marked this pull request as ready for review January 13, 2025 15:04
@ParkMyCar ParkMyCar requested review from a team as code owners January 13, 2025 15:04
@ParkMyCar ParkMyCar requested review from aljoscha and jkosh44 January 13, 2025 15:04
Copy link
Contributor

@jkosh44 jkosh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we need to update the migration PR to migrate all source webhooks to tables?

@ParkMyCar
Copy link
Member Author

LGTM, do we need to update the migration PR to migrate all source webhooks to tables?

Yeah we should, I'll file an issue for that

* changes in planning to use the Table datatype
* update tests to assert previously missing issues
@ParkMyCar ParkMyCar force-pushed the webhook/create-table-fixes branch from f205d1b to da93684 Compare January 14, 2025 15:50
@ParkMyCar ParkMyCar enabled auto-merge (squash) January 14, 2025 16:28
@ParkMyCar ParkMyCar merged commit 0f87de3 into MaterializeInc:main Jan 14, 2025
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants