Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import rewrite issues #607

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: import rewrite issues #607

merged 2 commits into from
Jan 24, 2025

Conversation

petermasking
Copy link
Member

Fixes #606

Changes proposed in this pull request:

  • rewrite imports without members to common imports (fixes case 1);
  • filter import keys bases on the actual import / export members (fixes case 2);
  • skip segmented modules without members (bonus fix).

@MaskingTechnology/jitar

@petermasking petermasking linked an issue Jan 22, 2025 that may be closed by this pull request
Import rewrite issues #606
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@basmasking basmasking merged commit 5c7c58f into main Jan 24, 2025
22 checks passed
@basmasking basmasking deleted the 606-import-rewrite-issues branch January 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basmasking basmasking basmasking approved these changes

Assignees

@basmasking basmasking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import rewrite issues
2 participants
@petermasking @basmasking