chore(build): migrate to eslint 9 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Oct 11, 2024
packages/health/src/HealthManager.ts
Outdated
Comment on lines
68
to
75
| if (result.status === 'fulfilled') | ||
| { | ||
| healthChecks.set(result.value.name, result.value.isHealthy); | ||
| } | ||
| else | ||
| { | ||
| healthChecks.set(result.reason.name, false); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (result.status === 'fulfilled') | |
| { | |
| healthChecks.set(result.value.name, result.value.isHealthy); | |
| } | |
| else | |
| { | |
| healthChecks.set(result.reason.name, false); | |
| } | |
| if (result.status !== 'fulfilled') | |
| { | |
| healthChecks.set(result.reason.name, false); | |
| return; | |
| } | |
| healthChecks.set(result.value.name, result.value.isHealthy); |
More clean code.
| @@ -1,4 +1,5 @@ | |||
|
|
|||
| /* eslint-disable @typescript-eslint/class-literal-property-style */ | |||
There was a problem hiding this comment.
Suggested change
| /* eslint-disable @typescript-eslint/class-literal-property-style */ | |
| // eslint-disable @typescript-eslint/class-literal-property-style |
Style consistency
packages/http/src/HttpServer.ts
Outdated
Comment on lines
162
to
166
| { | ||
| url: { type: 'url', required: true }, | ||
| procedureNames: { type: 'list', required: true, items: { type: 'string' } }, | ||
| trustKey: { type: 'string', required: false } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| { | |
| url: { type: 'url', required: true }, | |
| procedureNames: { type: 'list', required: true, items: { type: 'string' } }, | |
| trustKey: { type: 'string', required: false } | |
| }); | |
| { | |
| url: { type: 'url', required: true }, | |
| procedureNames: { type: 'list', required: true, items: { type: 'string' } }, | |
| trustKey: { type: 'string', required: false } | |
| } | |
| ); |
| @@ -15,7 +15,7 @@ type Configuration = | |||
| const DEFAULT_INDEX_FILENAME = 'index.html'; | |||
| const DEFAULT_SERVE_INDEX_ON_NOT_FOUND = false; | |||
|
|
|||
| export default class LocalRepository implements Repository | |||
| export default class LocalRepository implements ProviderService | |||
There was a problem hiding this comment.
Suggested change
| export default class LocalRepository implements ProviderService | |
| export default class LocalRepository implements Repository |
I prefer to keep the (empty) Repository interface for semantics and consistency reasons.
|
petermasking
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535
@MaskingTechnology/jitar