Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add llama index's ollama embedding and fix type hint of embedding_model #1071

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

rjwharry
Copy link
Contributor

@rjwharry rjwharry commented Jan 19, 2025

Resolve #1070

  • Add llama index's OllamaEmbedding class.
  • Separate original add_from_dict function to add_from_dict and add_from_list. Because of get_param_combinations, modules will get embedding_model config as dictionary not list. But vectordb will get it as list. So I separate to two functions to handle both cases.
  • Unify the way of loading embedding model.

@rjwharry rjwharry marked this pull request as ready for review January 19, 2025 13:59
Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks:)

@vkehfdl1 vkehfdl1 merged commit cb406f2 into Marker-Inc-Korea:main Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Ollama Embedding
2 participants