fix: refactor method to properly release vllm instance resources #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have investigated the related issue(#1003), and it seems that the root cause of the problem is the complexity involved in removing the allocated resources.
The issue did not occur when only a single task was performed, as shown below:
However, after adding another scenario, the error occurred. It seems that the error arose during the process of reinitializing the vllm model when the following change was made:
I have addressed this issue in the code, and I would appreciate it if you could review it.
This PR only addresses the changes related to the destructor, and I will add further details regarding the issue on the issue page.
Thank you.
references