Refactor testing of flash messages #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases to assign_all, unassign_all, and unassign_single methods
Implement custom matcher for have_message and contain_message Refactor marks_graders_controller_spec notes_controller_spec peer_reviews_controller_spec
… test-message-refactor
Pull Request Test Coverage Report for Build 12997204113Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
@Raine-Yang-UofT nice work! I left some inline comments; please also make sure to update the changelog as well.
spec/support/custom_matchers.rb
Outdated
| end | ||
| end | ||
|
|
||
| def strip_html(text) |
There was a problem hiding this comment.
It isn't necessary to define this custom function. Instead, reuse the existing extract_text helper, which was previously used to process some of the flash messages.
spec/support/custom_matchers.rb
Outdated
| end | ||
|
|
||
| failure_message do |actual| | ||
| actual_stripped = Array(actual).map { |m| strip_html(m.to_s) } |
There was a problem hiding this comment.
We should wrap this block (and the similar one in :contain_message in a :nocov: so that it isn't included in the coverage report.
david-yz-liu
approved these changes
Jan 27, 2025
soheegoo
pushed a commit
to soheegoo/Markus
that referenced
this pull request
Jan 27, 2025
Introduce custom matchers have_message and contain_message for checking flash messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Implement custom Rspec matchers
contain_messageandhave_messagethat verifies the content of flash messages.Refactor all existing unit tests to use the new matcher.
...
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)