Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Chrome --headless=new option in testing #6990

Merged

Conversation

david-yz-liu
Copy link
Collaborator

@david-yz-liu david-yz-liu commented Mar 3, 2024

Motivation and Context

Trying out this new option. Ref teamcapybara/capybara#2726.

Your Changes

Description: Set Selenium tests to use --headless=new Chrome option.

Type of change (select all that apply):

  • Test update (change that modifies or updates tests only)

Testing

Opened this PR and checked that the tests pass.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8131963564

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.771%

Totals Coverage Status
Change from base Build 8131934753: 0.0%
Covered Lines: 39137
Relevant Lines: 42024

💛 - Coveralls

@david-yz-liu david-yz-liu requested a review from donny-wong March 12, 2024 22:04
@david-yz-liu david-yz-liu merged commit a9e1ecd into MarkUsProject:master Mar 30, 2024
6 checks passed
@david-yz-liu david-yz-liu deleted the selenium-headless-new branch March 30, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants