Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6677] Account for duration for timed assessments to determine if grading can begin #6845

Merged

Conversation

TheTallJerry
Copy link
Member

@TheTallJerry TheTallJerry commented Nov 30, 2023

Motivation and Context

This PR resolves #6677.

When determining when an assessment becomes gradable, the current code doesn't take into account the duration of timed assessments. A timed assessment that can be started between 2023-12-01 03:00 and 2023-12-04 03:00 with a duration of 2 hours, should be gradable after 2023-12-04 05:00, not after 2023-12-04 03:00.

Your Changes

Description:
Takes into account the duration of timed assessments when determining when they become gradable, evident from the flash messages displayed as mentioned in #6677.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (internal change to codebase, without changing functionality)
  • Test update (change that modifies or updates tests only)

Testing

Added unit tests:

  • Timed assessments become gradable after due_date + duration
  • Not timed assessments become gradable after due_date

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have added tests for my changes.
  • I have updated the Changelog.md file.

@TheTallJerry TheTallJerry force-pushed the fix-grading-can-begin-flash branch from 35b5742 to 4b3fb97 Compare December 1, 2023 16:09
@TheTallJerry TheTallJerry changed the title [#6667] Account for duration for timed assessments to determine if grading can begin [#6677] Account for duration for timed assessments to determine if grading can begin Dec 1, 2023
@TheTallJerry TheTallJerry force-pushed the fix-grading-can-begin-flash branch from 3371863 to d8d8377 Compare December 1, 2023 16:28
@TheTallJerry TheTallJerry marked this pull request as ready for review December 1, 2023 16:30
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7062607185

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.882%

Totals Coverage Status
Change from base Build 7047766771: 0.003%
Covered Lines: 38419
Relevant Lines: 41257

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit ce9def1 into MarkUsProject:master Dec 2, 2023
@TheTallJerry TheTallJerry deleted the fix-grading-can-begin-flash branch December 8, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timed assessments: "Can begin grading" message doesn't take into account duration
3 participants