docs(rubric-criterion-denominator): changelog

MarkUsProject · Jan 12, 2025 · 3b764d9 · 3b764d9
1 parent b815ebe
commit 3b764d9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -9,6 +9,7 @@
 ### 🐛 Bug fixes
 
 - Ensures row selection for peer reviewer unassigning has the same validation checks as individual selections (#7274)
+- Ensures mark levels on a rubric criterion are properly scaled when its max mark is updated (#7311)
 
 ### 🔧 Internal changes
 

diff --git a/spec/models/rubric_criterion_spec.rb b/spec/models/rubric_criterion_spec.rb
@@ -140,6 +140,7 @@
         level_names = ['Level 1', 'Level 2', 'Level 3']
         old_marks = level_names.map { |name| rubric.levels.find { |level| level.name == name }.mark }
 
+        rubric.update!(max_mark: 8.0)
         rubric.update_levels(levels_attributes, 2.0)
         rubric.reload
 
@@ -150,6 +151,7 @@
       end
 
       it 'does not scale level marks if they have been changed in levels_attributes' do
+        rubric.update!(max_mark: 8.0)
         rubric.update_levels(levels_attributes, 2.0)
         rubric.reload
 
@@ -162,6 +164,7 @@
       end
 
       it 'does not scale marks for any new levels in level_attributes' do
+        rubric.update!(max_mark: 8.0)
         rubric.update_levels(levels_attributes, 2.0)
         rubric.reload