common: Handle empty lib_paths gracefully
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #285 to fix the CI failures. |
Manishearth
approved these changes
Mar 5, 2024
vadorovsky
force-pushed
the
empty-lib-paths
branch
from
c730739 to
bfb22a1
Compare
`env::split_paths()` called with an empty string, yields one empty string. This behavior is not really compatible with the forloop it's used in, which in such case is going to produce ` -L ` not followed by any path. This causes rustc to fail. To prevent this issue, enter the loop only when `lib_paths` is not empty. That issue was reproducable on MacOS, where `lib_paths` often ends up being empty.
vadorovsky
force-pushed
the
empty-lib-paths
branch
from
bfb22a1 to
f1eba66
Compare
Manishearth
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env::split_paths()called with an empty string, yields one empty string. This behavior is not really compatible with the forloop it's used in, which in such case is going to produce-Lnot followed by any path. This causes rustc to fail.To prevent this issue, enter the loop only when
lib_pathsis not empty.That issue was reproducable on MacOS, where
lib_pathsoften ends up being empty.