Fail fast if transport is null, check for null on close

MangoAutomation · Nov 2, 2023 · 1e02fd7 · 1e02fd7
1 parent 9c7adae
commit 1e02fd7
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/com/serotonin/modbus4j/sero/messaging/MessageControl.java b/src/com/serotonin/modbus4j/sero/messaging/MessageControl.java
@@ -52,6 +52,9 @@ public class MessageControl implements DataConsumer {
      */
     public void start(Transport transport, MessageParser messageParser, RequestHandler handler,
             WaitingRoomKeyFactory waitingRoomKeyFactory) throws IOException {
+        if (transport == null) {
+            throw new IllegalArgumentException("transport cannot be null");
+        }
         this.transport = transport;
         this.messageParser = messageParser;
         this.requestHandler = handler;
@@ -64,7 +67,9 @@ public void start(Transport transport, MessageParser messageParser, RequestHandl
      * <p>close.</p>
      */
     public void close() {
-        transport.removeConsumer();
+        if (transport != null) {
+            transport.removeConsumer();
+        }
     }
 
     /**