Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckReconfigured method refactoring . #48

Merged
merged 2 commits into from
Mar 31, 2017
Merged

CheckReconfigured method refactoring . #48

merged 2 commits into from
Mar 31, 2017

Conversation

pkomanek
Copy link
Contributor

Purpose or Intent

Refactoring ManageIQ/Cloud/Orchestration/Reconfiguration/CheckReconfigured method and adding a new spec. This PR is based on the issue bellow.

Links [Optional]

#8

@miq-bot miq-bot added the wip label Feb 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

Checked commits pkomanek/manageiq-content@d1022c8~...588a1a1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 👍

@pkomanek pkomanek changed the title [WIP]CheckReconfigured method refactoring . CheckReconfigured method refactoring . Feb 16, 2017
@miq-bot miq-bot removed the wip label Feb 16, 2017
@pkomanek
Copy link
Contributor Author

@miq-bot add_label refactoring

@mkanoor mkanoor self-requested a review March 31, 2017 14:19
@mkanoor mkanoor self-assigned this Mar 31, 2017
@mkanoor mkanoor merged commit af53a8c into ManageIQ:master Mar 31, 2017
@mkanoor mkanoor added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
simaishi pushed a commit that referenced this pull request Mar 31, 2017
…check_reconfigured_method

CheckReconfigured method refactoring .
(cherry picked from commit af53a8c)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit ff5009ee285ed8f258c57f33a65f6e64070b21fe
Author: Madhu Kanoor <[email protected]>
Date:   Fri Mar 31 10:20:41 2017 -0400

    Merge pull request #48 from pkomanek/refactoring_cloud_orchestration_check_reconfigured_method
    
    CheckReconfigured method refactoring .
    (cherry picked from commit af53a8c170c8741c2eafc5a5d8e22cd3df7b77d9)

@pkomanek pkomanek deleted the refactoring_cloud_orchestration_check_reconfigured_method branch April 3, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants