Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring ServiceTemplateProvisionRequestApproved method #31

Closed
wants to merge 2 commits into from
Closed

Refactoring ServiceTemplateProvisionRequestApproved method #31

wants to merge 2 commits into from

Conversation

pkomanek
Copy link
Contributor

@pkomanek pkomanek commented Feb 2, 2017

Purpose or Intent

Refactoring ServiceTemplateProvisionRequestApproved method and adding a new spec for that. This PR is based on the issue bellow.

Links [Optional]

#8

@miq-bot
Copy link
Member

miq-bot commented Feb 2, 2017

Checked commits pkomanek/manageiq-content@5be2fcf~...3d34177 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@pkomanek pkomanek closed this Feb 7, 2017
@pkomanek pkomanek reopened this Feb 7, 2017
@mkanoor
Copy link
Contributor

mkanoor commented Feb 7, 2017

@pkomanek
@billfitzgerald0120 is working on consolidating the email methods so we should not work on this method till his changes are merged. His change removes remove the need for methods and are controlled by instances and a single shared method.

@pkomanek pkomanek closed this Feb 8, 2017
@pkomanek pkomanek deleted the refactoring_servicetemplateprovisionrequest_approved_method branch June 5, 2018 07:55
@pkomanek pkomanek restored the refactoring_servicetemplateprovisionrequest_approved_method branch June 5, 2018 07:55
@pkomanek pkomanek deleted the refactoring_servicetemplateprovisionrequest_approved_method branch June 5, 2018 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants