Refactoring cloud vm retirement start_retirement method #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Mar 7, 2018
| def vm_validation | ||
| if @vm.nil? | ||
| @handle.log('error', "VM Object not found") | ||
| exit MIQ_ABORT |
There was a problem hiding this comment.
@pkomanek
Raise exception instead of exiting
mkanoor
reviewed
Mar 7, 2018
| $evm.create_notification(:type => :vm_retiring, :subject => vm) | ||
| if @vm.retired? | ||
| @handle.log('error', "VM is already retired. Aborting current State Machine.") | ||
| exit MIQ_ABORT |
mkanoor
reviewed
Mar 7, 2018
| vm.start_retirement | ||
| if @vm.retiring? | ||
| @handle.log('error', "VM is in the process of being retired. Aborting current State Machine.") | ||
| exit MIQ_ABORT |
mkanoor
reviewed
Mar 7, 2018
|
|
||
| it "with retiring vm" do | ||
| svc_vm.start_retirement | ||
| expect { described_class.new(ae_service).main }.to raise_error(SystemExit) |
There was a problem hiding this comment.
@pkomanek Change this to catch the exception
|
Checked commits pkomanek/manageiq-content@4e69fdf~...049abed with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
billfitzgerald0120
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
@pkomanek I tested this using an Openstack instance. Looks Good.
pkomanek
deleted the
refactoring_cloud_vm_retirement_statemachines_methods_StartRetirement_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring Cloud/VM/Retirement/StateMachines/Methods.class/methods/start_retirement.rb method with spec. This PR is based on the issue bellow.
Links
#8
@miq-bot add_label refactoring