Refactoring cloud vm retirement remove_from_provider method #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Jun 5, 2018
| unregister | ||
| else | ||
| @handle.log('info', "Unknown retirement type for VM:<#{@vm.name}> from provider:<#{@ems.name}>") | ||
| exit MIQ_ABORT |
There was a problem hiding this comment.
@pkomanek
Can this be a raise, we tend to discourage exits from inside of method since it makes rspec to exit and difficult to debug. When these methods run as part of the Engine we fork a process and there the exit doesn't hurt but when we test it using the mocks and outside of the engine the exit has different behavior since its running directly under rspec.
mkanoor
reviewed
Jun 5, 2018
| $evm.log('info', "Skipping remove from provider for Instance:<#{vm.try(:name)}> on provider:<#{ems.try(:name)}>") | ||
| exit MIQ_OK | ||
| end | ||
| if @vm.nil? || @ems.nil? |
There was a problem hiding this comment.
@pkomanek
Can we drop the exit MIQ_OK in favor of
if @vm && @ems
remove_vm
else
@handle.log('info', "Skipping remove from provider for Instance:<#{@vm.try(:name)}> on provider:<{@ems.try(:name)}>")
end
|
Checked commits pkomanek/manageiq-content@9980cc5~...1b76d5e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
Jun 13, 2018
pkomanek
deleted the
refactoring_cloud_vm_retirement_statemachines_methods_RemoveFromProvider_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring Cloud/VM/Retirement/StateMachines/Methods.class/methods/remove_from_provider.rb method with spec. This PR is based on the issue bellow.
Links
#8
@miq-bot add_label refactoring