deploy: drop one-off use of the "service" wrapper #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`service <name> [args]` is a small wrapper for `/etc/init.d/<name> [args]`. dewclaw already makes several direct calls to `/etc/init.d/config_generation`, and the one-off `service config_generation` call confused me (I had to look up the implementation in OpenWrt). I think it's better to call the script the same way everywhere.
|
...unless I've completely misunderstood something fundamental :-D |
MakiseKurisu
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service <name> [args]is a small wrapper for/etc/init.d/<name> [args]. dewclaw already makes several direct calls to/etc/init.d/config_generation, and the one-offservice config_generationcall confused me (I had to look up the implementation in OpenWrt). I think it's better to call the script the same way everywhere.