Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3848/gitlog with authors #3897

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Jan 28, 2025

CCjson from Gitlogparser with Authors cannot be imported

Closes: #3848

Description

Added a remove Authors function that removes all Authors Attributes.
For every removed Authors Attribute there is a warning created.
Removing the Authors is done before validating the cc.json, so the automatic creating of the "generatedSchema.json" can still be used.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 just quick question whyis authors there if we do not need it in the first place? don't we parse this ourselves in ccsh?

@BenediktMehl BenediktMehl enabled auto-merge (rebase) January 31, 2025 13:32
auto-merge was automatically disabled January 31, 2025 13:38

Rebase failed

@BenediktMehl BenediktMehl force-pushed the bug/3848/gitlog-with-authors branch from 88ed1a2 to aade454 Compare January 31, 2025 13:43
@BenediktMehl BenediktMehl enabled auto-merge (rebase) January 31, 2025 13:43
Copy link

Copy link

@BenediktMehl BenediktMehl merged commit fddcfcb into main Jan 31, 2025
8 checks passed
@BenediktMehl BenediktMehl deleted the bug/3848/gitlog-with-authors branch January 31, 2025 13:56
@BenediktMehl
Copy link
Collaborator Author

BenediktMehl commented Jan 31, 2025

Code looks good 👍 just quick question whyis authors there if we do not need it in the first place? don't we parse this ourselves in ccsh?

Yes you are right, at the moment it's not really used in the vis part, but it can be exported in the analysis (no body knows why we have this already). But the idea is to give some functionality to that in the future, which is why we wanted to fix the bug, instead of removing the feature in the ana part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CCjson from Gitlogparser with Authors cannot be imported
2 participants