Improve quality of existing matcher #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many of the matchers were created after 2am, 18 hours into a weekend hackathon. Does matching the |
|
It possibly would be, although that change would be beyond the scope of this PR. I raised issue #96 to discuss the state of the matchers and try to decide on a way to move forward with them. |
jamescowie
pushed a commit
that referenced
this pull request
May 13, 2015
Improve quality of existing matcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just addressing outstanding Scrutinizer issues with the existing matcher. It does not attempt to work towards the decisions required for #96.