Merge pull request #6 from maffiemd/restructure-manuscript-schema

Remove Unused Properties From Manuscript Object
MaffieLab · Nov 14, 2023 · cc0b434 · cc0b434
2 parents a1e4e1c + 80faf57
commit cc0b434
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/src/content.ts b/src/content.ts
@@ -110,24 +110,22 @@ const getDecisionData = () => {
     const manuscriptID = row.cells[index.ID].textContent!.trim();
     data["manuscriptID"] = manuscriptID;
     data["journal"] = journal;
+    let submission_date: string = "";
     try {
-      const submission_date = row.cells[index.Submitted].textContent!.trim();
-      data["submission_date"] = submission_date;
+      submission_date = row.cells[index.Submitted].textContent!.trim();
     } catch (error) {
-      const submission_date = row.cells[index.Created].textContent!.trim();
-      data["submission_date"] = submission_date;
+      submission_date = row.cells[index.Created].textContent!.trim();
     }
     const status = row.cells[index.Status];
     const decision = getDecisionType(status);
     if (!decision) {
       continue;
     }
     data["decision"] = decision!.decision;
-    data["decisioned_date"] = decision!.decisionDate;
-    const days = daysUnderReview(data.submission_date, data.decisioned_date);
+    const days = daysUnderReview(submission_date, decision!.decisionDate);
     data["days"] = days;
     data["journalFullName"] = journalFullName;
-    data["year"] = new Date(data["submission_date"]).getFullYear();
+    data["year"] = new Date(submission_date).getFullYear();
     ms_data.push(data);
   }
   return ms_data;

diff --git a/src/tests/destructure.test.ts b/src/tests/destructure.test.ts
@@ -6,21 +6,15 @@ describe("Destructure manuscript function", () => {
     {
       manuscriptID: "id1",
       journal: "",
-      submission_date: "",
-      title: "",
       decision: "",
-      decisioned_date: "",
       days: 0,
       year: 0,
       journalFullName: "",
     },
     {
       manuscriptID: "id2",
       journal: "",
-      submission_date: "",
-      title: "",
       decision: "",
-      decisioned_date: "",
       days: 0,
       year: 0,
       journalFullName: "",

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -8,10 +8,7 @@ export interface JournalStats {
 export interface Manuscript {
   manuscriptID: string;
   journal: string;
-  submission_date: string;
-  title: string;
   decision: string;
-  decisioned_date: string;
   days: number;
   year: number;
   journalFullName: string;
@@ -20,10 +17,7 @@ export interface Manuscript {
 export const newManuscript = (): Manuscript => ({
   manuscriptID: "",
   journal: "",
-  submission_date: "",
-  title: "",
   decision: "",
-  decisioned_date: "",
   days: 0,
   year: 0,
   journalFullName: "",

diff --git a/tsconfig.json b/tsconfig.json
@@ -29,7 +29,7 @@
     // https://stackoverflow.com/questions/43042889/typescript-referenceerror-exports-is-not-defined
     "module": "es2020" /* Specify what module code is generated. */,
     "rootDir": "./src" /* Specify the root folder within your source files. */,
-    "moduleResolution": "node10",                     /* Specify how TypeScript looks up a file from a given module specifier. */
+    "moduleResolution": "node10" /* Specify how TypeScript looks up a file from a given module specifier. */,
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
     // "paths": {},                                      /* Specify a set of entries that re-map imports to additional lookup locations. */
     // "rootDirs": [],                                   /* Allow multiple folders to be treated as one when resolving modules. */