-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My improvements #173
Draft
MaddTheSane
wants to merge
26
commits into
MacPaw:master
Choose a base branch
from
MaddTheSane:backToUpstream1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
My improvements #173
+2,984
−1,430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e12ac73
to
d1796be
Compare
ca4cae9
to
0c163f1
Compare
… XADArchiveKeys as typed extensible enums. Also wrap local includes in "#pragma clang diagnostic" to prevent warnings.
Also add NS_ENUM macro, and expand API_DEPRECATED_WITH_REPLACEMENT to point to the replacement. Also fix some deprecation warnings.
8431205
to
b2bdaca
Compare
Add XADEXPORT to public classes, and XADEXTERN to public functions. Add missing XADStringEncodingName renames in XADPath. Make XADAction an NS_ENUM.
b2bdaca
to
9b891eb
Compare
a79d82f
to
fe11b8f
Compare
…DErrorDomain better map to XADErrors. Use our own custom macro to keep XADError the same size, as NS_ERROR_ENUM uses NSInteger. Also rename the error values to make them look pretty under Swift.
93f5f71
to
fed64c6
Compare
Fixed a couple of memory leaks.
But we need to also migrate from typeAlias to either typeFileURL or typeBookmarkData, as the Alias Manager is deprecated.
…erty declarations.
6bbfcb7
to
ef6aa4d
Compare
a96c995
to
c2c13a1
Compare
c2c13a1
to
d6d6e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft is where I want to push some of the changes that I've implemented in my own fork. Most of these are to increase interoperability with Swift. The first commit was migrating from informal protocols to formal protocols with optionals. This is very much a project that I do want feedback on.
Other planned additions include:
NS_ENUM
/NS_OPTIONS
where appropriate.NS_TYPED_ENUM
/NS_TYPED_EXTENSIBLE_ENUM
where appropriateNSError
methods to better work with Swift (My fork wraps the exception-throwing methods, catches the exception, then converts it into an equivalentNSError
. A better way would be to migrate as much of the code to useNSError
s only. Relevant code: Link ).@property
s, for-in loops, and(this will depend on what other architectures actually support).@autoreleasepool
A lot of these can be accomplished with using macros on non-Apple platforms (See here for an example).
What I will not (or try not to) do, mainly because the non-Apple runtimes and/or compilers don't support them:
What needs to be discussed: