-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - Utilisateur] UI / UX pour utilisateurs multi-territoire #3554
Conversation
1d7b17e
to
ddf263d
Compare
e912ef4
to
1b5515e
Compare
} | ||
}) | ||
}else{ | ||
const content = '<div class="fr-alert fr-alert--error" role="alert"><p class="fr-alert__title">Erreur</p><p>Une erreur est survenue veuillez fermer cette fenêtre.</p></div>' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On pourrait faire plus précis ? Genre fermer la fenêtre, rafraichir la page, et réessayer ? J'imagine que ça peut se produire en cas de perte de session ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok (j'ai repris le message qu'on utilise a chaque fois)
|
||
return $this->json(['redirect' => true, 'url' => $url]); | ||
} | ||
$formMultiMail->get('email')->addError(new FormError('Agent introuvalbe avec cette adresse e-mail.')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
introuvable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, merci
</table> | ||
<p>Si le bouton ne fonctionne pas <a href="{{ link|raw }}" target="_blank" rel="noopener">cliquez ici</a></p> | ||
<p> | ||
Pour plus d'information, rapprochez vous de votre référent territorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rapprochez-vous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut mettre "responsable de territoire", pour garder le même terme partout ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pas touché celui-la vu le terme utilisé dans les autre e-mail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut mettre "responsable de territoire" dans tous les mails ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bon d'accord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, étant donné les choix précédents, j'aurais vérifié avec Mathilde avant. Si elle a proposé ce terme-là dans les e-mails, ça doit pas être pour rien, à mon avis !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques commentaires de typo. Sinon relecture et tests ok de ce que j'ai vu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests OK
@@ -15,9 +15,8 @@ | |||
<div class="fr-select-group"> | |||
Vous êtes sur le point de supprimer le compte utilisateur de <span class="fr-modal-user-delete_username"></span> (<span class="fr-modal-user-delete_useremail"></span>). Une fois le compte supprimé : | |||
<ul class="fr-list"> | |||
<li><span class="fr-modal-user-delete_username"></span> ne pourra plus se connecter à la plateforme {{ platform.name }} pour traiter des signalements.</li> | |||
<li><span class="fr-modal-user-delete_username"></span> ne pourra plus traiter des signalements sur le territoire.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s'il n'a qu'un partenaire, ou si c'est le dernier partenaire, il ne pourra plus se connecter non plus, si ?
</table> | ||
<p>Si le bouton ne fonctionne pas <a href="{{ link|raw }}" target="_blank" rel="noopener">cliquez ici</a></p> | ||
<p> | ||
Pour plus d'information, rapprochez vous de votre référent territorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut mettre "responsable de territoire" dans tous les mails ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok pour moi
Quality Gate failedFailed conditions |
Ticket
#3308
Description
FEATURE_MULTI_TERRITORIES
Pré-requis
FEATURE_MULTI_TERRITORIES=1
make load-fixtures
Tests
FEATURE_MULTI_TERRITORIES=0