Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Revoir le SuiviFactory/SuiviManager #3532

Merged
merged 4 commits into from
Jan 16, 2025
Merged

[QA] Revoir le SuiviFactory/SuiviManager #3532

merged 4 commits into from
Jan 16, 2025

Conversation

numew
Copy link
Collaborator

@numew numew commented Jan 8, 2025 •
edited
Loading

Ticket

#3052

Description

Refacto et simplification des SuiviFactory et SuiviManager (on n egarde plus que SuiviManager, seul point d'entrée de création de suivi)

Tests

  • Tester différent process de création de suivi et s'assurer que le fonctionnement n'a pas changé

@numew numew requested review from hmeneuvrier, sfinx13 and emilschn and removed request for hmeneuvrier and sfinx13 January 8, 2025 15:15
@numew numew force-pushed the feature/3052-refacto-suivi-factory-manager branch from ff0a5a0 to 18550a0 Compare January 8, 2025 16:59
@hmeneuvrier
Copy link
Collaborator

hmeneuvrier commented Jan 10, 2025 •
edited
Loading

Créations de suivi :

  • Demande de feedback
  • usager abandonne ou poursuit la proccédure
  • usager ajoute un suivi
  • Notification visite
  • synchronisation Idoss
  • synchronisation esabora (avec arrêté par exemple)
  • validation d'un signalement
  • demande de fichier après 30 minutes
  • modification d'une partie du signalement
  • ajout de fichier à un signalement
  • partenaire accepte ou refuse affectation
  • création d'une visite
  • édition d'une visite
  • annulation d'une visite
  • canceclation d'une visite
  • confirmation d'une visite
  • replanificcation d'une visite
  • fermeture d'un signalement

hmeneuvrier
hmeneuvrier approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relecture et tests OK

emilschn
emilschn reviewed Jan 10, 2025
View reviewed changes
src/Factory/SuiviFactory.php Outdated
$partner = $user->getPartnerInTerritoryOrFirstOne($signalement->getTerritory());
if ($nbDocs > 0) {
$description .= \sprintf(
'%s a ajouté %s %s de la visite du %s :',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enlever "de la visite" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vois pas pourquoi, j'ai laissé tel quel

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je crois que ça faisait un truc bizarre genre "rapport de visite de la visite du"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui et c'est bien ce que désigne le message, tu voudrais quoi ? (si on met "rapport de visite du xx" la phrase perd sons sens, c'est bien la date de la visite que l'on indique à chaque fois, pas celle du rapport)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si tu y tiens, moi je pense que "Rapport de visite du XX", on comprend.
Ou alors "Rapport de la visite du XX".
Mais pas de souci :)

sfinx13
sfinx13 reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture OK (pas certain d'avoir le temps de tester)

sfinx13
sfinx13 reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faire une recherche sur new Suivi() et vérifier qu'il en reste plus qu'un. (hors migration et test)
image

@numew numew force-pushed the feature/3052-refacto-suivi-factory-manager branch from 56b5338 to 59c61e4 Compare January 14, 2025 12:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sfinx13
sfinx13 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

@emilschn emilschn merged commit d2ff7f2 into develop Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn left review comments

@hmeneuvrier hmeneuvrier hmeneuvrier approved these changes

@sfinx13 sfinx13 sfinx13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@numew @hmeneuvrier @emilschn @sfinx13