-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BO - Date d'entrée] Correction du type de champ pour la date d'entrée du logement dans le formulaire NDE #3507
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -487,7 +484,8 @@ public function updateFromInformationsLogementRequest( | |||
->setBailDpeBail($informationsLogementRequest->getBailDpeBail()) | |||
->setBailDpeEtatDesLieux($informationsLogementRequest->getBailDpeEtatDesLieux()) | |||
->setBailDpeDpe($informationsLogementRequest->getBailDpeDpe()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans la modale NDE, je met "non" pour DPE, dans l'information logement c'est toujours "oui" (et, si je met ensuite "ne sait pas" dans information logement, ça reste à "non" dans la partie NDE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok c'est corrigé !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je ne vois pas les changements, cc'est aussi un bug de rafraichissement ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En fait, si je change dans la modale NDE, ce n'est pas répercucté dans l'onglet Foyer / Informations sur le logement.
Mais l'inverse fonctionne bien
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trop bizarre... Je vais voir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, j'ai compris : dans ce sens, c'est quand le DPE était false (et donc empty) que ça ne marchait pas... c'est corrigé !
084d55e
to
c35ae9c
Compare
Quality Gate passedIssues Measures |
Ticket
#3435
Description
Depuis le nouveau formulaire, on enregistre la vraie date d'entrée dans le logement.
Malheureusement, la modale pour éditer la NDE écrase cette donnée avec des dates arbitraires (01/01/1970 et 02/01/2023) qui servaient à savoir si on était avant ou après 2023.
Heureusement, on a conservé la donnée enregistrée à la base dans le formulaire.
Changements apportés
Tests
make execute-migration name=Version20250102154204 direction=up