fix(mt3dms-p01): advection scheme was not behaving as expected #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emorway-usgs
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Changes look good to me. I just updated my version of ruff to 0.9...I was pretty far behind (ver. 0.5). The only thing I can think of is whether or not a note is needed in the release notes of MF6 indicating the description was updated - though I'm guessing that's not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the problem ex-gwt-mt3dms-p01, the text indicated that TVD was used to represent all four cases of this problem. The problem was actually using the upstream scheme for both mf6 and mt3dms. The description was modified to accurately reflect the scheme used for the problem.