Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump timdex-dataset-api to v0.3.0 #222

Closed
wants to merge 1 commit into from
Closed

Conversation

ghukill
Copy link
Contributor

@ghukill ghukill commented Dec 18, 2024

Purpose and background context

This PR bumps the version of library timdex-dataset-api (TDA) to v0.3.0. This version includes an updated partitioning schema and most of the write behavior established.

How can a reviewer manually see the effects of these changes?

Running tests indicates any usage of the TDA library is still successful.

Additionally, the following "v2" StepFunction run in Dev1 shows a successful "v2" run of Transmogrifier: https://us-east-1.console.aws.amazon.com/states/home?region=us-east-1#/v2/executions/details/arn:aws:states:us-east-1:222053980223:execution:timdex-ingest-v2-dev:fe6e9d6d-67f7-4250-8842-4e43ebd53c02, where files were written to s3://timdex-extract-dev-222053980223/dataset/year=2024/month=12/day=18/4cfc36e4-4bb5-4f85-aed2-cee91bcc588d-0.parquet.

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

What are the relevant tickets?

  • None

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed and verified
  • New dependencies are appropriate or there were no changes

@ghukill
Copy link
Contributor Author

ghukill commented Dec 19, 2024

On further thought, going to close out this PR.

The easiest way to keep the applications using the most current/stable version of the TDA library is likely just installing from the main branch (effectively what ever code the most recent PR established).

During development, we can certainly build Transmog with certain versions as needed (with make publish-dev), and can skip this PR route of establishing that.

@ghukill ghukill closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants