Address comments on PR #177

* Return log statement
* Define config-level constant: GIS_SOURCES

lambdas/commands.py

@@ -28,7 +28,7 @@ def generate_extract_command(
     if verbose:
         extract_command.append("--verbose")
 
-    if source in ["gismit", "gisogm"]:
+    if source in config.GIS_SOURCES:
         extract_command.append("harvest")
         if run_type == "daily":
             extract_command.append("--harvest-type=incremental")

lambdas/config.py

@@ -1,10 +1,11 @@
 import logging
 import os
 
+GIS_SOURCES = ["gismit", "gisogm"]
 INDEX_ALIASES = {
     "rdi": ["jpal", "whoas", "zenodo"],
     "timdex": ["alma", "aspace", "dspace"],
-    "geo": ["gismit", "gisogm"],
+    "geo": GIS_SOURCES,
 }
 REQUIRED_ENV = {
     "TIMDEX_ALMA_EXPORT_BUCKET_ID",
@@ -83,7 +84,7 @@ def validate_input(input_data: dict) -> None:
     # If next step is extract step, required harvest fields are present
     # ruff: noqa: SIM102
     if input_data["next-step"] == "extract":
-        if input_data["source"] not in ["gismit", "gisogm"]:
+        if input_data["source"] not in GIS_SOURCES:
             if missing_harvest_fields := [
                 field for field in REQUIRED_OAI_HARVEST_FIELDS if field not in input_data
             ]:

lambdas/format_input.py

@@ -1,3 +1,4 @@
+import json
 import logging
 import os
 
@@ -11,6 +12,7 @@ def lambda_handler(event: dict, _context: dict) -> dict:
     config.verify_env()
     verbose = config.check_verbosity(event.get("verbose", False))
     config.configure_logger(logging.getLogger(), verbose)
+    logger.debug(json.dumps(event))
     config.validate_input(event)
 
     run_date = helpers.format_run_date(event["run-date"])
@@ -27,7 +29,7 @@ def lambda_handler(event: dict, _context: dict) -> dict:
     }
 
     if next_step == "extract":
-        if source in ["gismit", "gisogm"]:
+        if source in config.GIS_SOURCES:
             result["harvester-type"] = "geo"
         else:
             result["harvester-type"] = "oai"

lambdas/helpers.py

@@ -55,7 +55,7 @@ def generate_step_output_filename(
     """
     sequence_suffix = f"_{sequence}" if sequence else ""
     if step == "extract":
-        file_type = "jsonl" if source in ["gismit", "gisogm"] else "xml"
+        file_type = "jsonl" if source in config.GIS_SOURCES else "xml"
     elif load_type == "delete":
         file_type = "txt"
     else: