Tco 69 data 2 #100
Closed
Tco 69 data 2 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reword this... tmp best commit message evah DO NOT MERGE: More verbose class diagram The changes here are still workshopping how we want to handle the data model - there isn't a single change that's being proposed yet. Add validation to code approach diagram
This takes the different prototype class diagrams out of docs/reference/classes.md and creates specific diagrams for both prototypes (along with a "prototype zero" option that was briefly considered and abandoned). It also writes up a workflow document for using each prototype, including sample code and output to try and illustrate the ideas motivating each option.
This is the first step toward the Data prototype for a categorization / validation workflow.
I wanted this to be just a Detector class, but that was conflicting with the Detector module name.
This also adds the Category field to the SuggestedResource model.
This should probably be squashed into the previous commit. Side effect: some of the SuggestedResource tests are now failing.
There are evaluate_* methods on the Terms model which will record link records in TermDetectinators for which detectors activate on a given term.
This is very much WIP
|
This branch is no longer needed. It was a practice copy of one of the main prototypes which contributed to the choice of categorization strategy, but was not unique in itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes (please refer to commit messages for full details)
Developer
Ticket(s)
https://mitlibraries.atlassian.net/browse/TCO-###
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
YES | NO dependencies are updated
YES | NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing