Code review feedback 2

Implement cassette scrubbing for cookie values None of these values are currently sensitive, but the possibility exists that future cassettes could store sensitive values in the Set-Cookie headers.
MITLibraries · Jan 13, 2025 · ea880f1 · ea880f1
1 parent 88da0dd
commit ea880f1
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 36 deletions.
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -38,6 +38,11 @@
     header&.each do |redacted_text|
       interaction.filter!(redacted_text, '<REDACTED_NEL>')
     end
+
+    header = interaction.response&.headers&.[]('Set-Cookie')
+    header&.each do |redacted_text|
+      interaction.filter!(redacted_text, '<FAKE_COOKIE_DATA>')
+    end
   end
 end
 

diff --git a/test/vcr_cassettes/barcode_39080027236626.yml b/test/vcr_cassettes/barcode_39080027236626.yml
diff --git a/test/vcr_cassettes/barcode_not_found.yml b/test/vcr_cassettes/barcode_not_found.yml
diff --git a/test/vcr_cassettes/pmid_37953305.yml b/test/vcr_cassettes/pmid_37953305.yml
diff --git a/test/vcr_cassettes/pmid_not_found.yml b/test/vcr_cassettes/pmid_not_found.yml