Rubocop cleanup: Security/Open

MITLibraries · Aug 12, 2024 · 0e91ff5 · 0e91ff5
1 parent db8b42b
commit 0e91ff5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -120,11 +120,6 @@ Rails/I18nLocaleTexts:
     - 'app/controllers/admin/application_controller.rb'
     - 'app/controllers/application_controller.rb'
 
-# Offense count: 1
-Security/Open:
-  Exclude:
-    - 'lib/tasks/journals.rake'
-
 # Offense count: 25
 # Configuration parameters: AllowedConstants.
 Style/Documentation:

diff --git a/lib/tasks/journals.rake b/lib/tasks/journals.rake
@@ -86,7 +86,7 @@ namespace :journals do
     # does the file look like a path or a URI
     if URI(args.file).scheme
       Rails.logger.info("Loading data from remote file #{args.file}")
-      data = URI.open(args.file, 'rb', &:read)
+      data = URI.parse(args.file).open('rb', &:read)
     else
       Rails.logger.info("Loading data from local file #{args.file}")
       data = File.read(args.file)