Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance 11 2024 #474

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Maintenance 11 2024 #474

merged 2 commits into from
Nov 20, 2024

Conversation

ehanson8
Copy link
Contributor

Purpose and background context

Updates app according to our maintenance week documentation.

How can a reviewer manually see the effects of these changes?

Run make test and make lint to confirm they still pass

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples verified
  • New dependencies are appropriate or there were no changes

* Add .pre-commit-config.yaml
* Update Makefile
* Update dependencies
@mitlib mitlib temporarily deployed to mitlibraries-maintenanc-4mrkgw November 12, 2024 17:04 Inactive
Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to run tests and linting, and changes are pretty minimal. I'm inclined to approve, with the caveat someone should run a test in Heroku and ensure it's working properly.

Is that something we can do before merging?

@jonavellecuerdo jonavellecuerdo temporarily deployed to mitlibraries-solenoid-staging November 20, 2024 21:30 Inactive
@jonavellecuerdo
Copy link
Contributor

jonavellecuerdo commented Nov 20, 2024

Able to run tests and linting, and changes are pretty minimal. I'm inclined to approve, with the caveat someone should run a test in Heroku and ensure it's working properly.

Is that something we can do before merging?

@ehanson8 Can assist with this! I deployed the feature branch to the Heroku app in staging and can confirm a test import ran successfully.

@ehanson8 ehanson8 merged commit 53dbd85 into main Nov 20, 2024
2 checks passed
@ehanson8 ehanson8 deleted the maintenance-11-2024 branch November 20, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants