Resolve 'mypy' linting errors (p2)

Pipfile

@@ -18,6 +18,8 @@ pytest = "*"
 pytest-django = "*"
 requests-mock = "*"
 ruff = "*"
+types-beautifulsoup4 = "*"
+types-requests = "*"
 
 [packages]
 # Only needed for Heroku

pyproject.toml

@@ -2,22 +2,29 @@
 line-length = 90
 
 [tool.django-stubs]
-django_settings_module = "solenoid.settings"
+django_settings_module = "solenoid.settings.base"
 
 [tool.mypy]
 disallow_untyped_calls=true
-disallow_untyped_defs=true
+disallow_untyped_defs=false
 exclude=[
-    "solenoid/wsgi.py",
-    "solenoid/accounts/migrations", 
-    "solenoid/elements/migrations", 
-    "solenoid/emails/migrations",
-    "solenoid/people/migrations/",
-    "solenoid/records/migrations/"
+    "^solenoid/.*/tests/.*",
+    "^solenoid/.*/migrations/.*",
+    "solenoid/wsgi.py"
 ]
 plugins = ["mypy_django_plugin.main"]
 
 [[tool.mypy.overrides]]
 module = ["solenoid.elements.xml_handlers"]
 disable_error_code = ["union-attr"]
 
+[[tool.mypy.overrides]]
+module = [
+    "celery_progress.backend",
+    "ckeditor.fields",
+    "ckeditor.widgets",
+    "debug_toolbar",
+    "environ"
+]
+ignore_missing_imports = true
+

solenoid/people/models.py

@@ -19,18 +19,18 @@
 # unending recursion, so we're following the suggestion in the documentation:
 # https://docs.djangoproject.com/en/1.8/topics/db/queries/#deleting-objects
 class ProtectiveQueryset(QuerySet):
-    def delete(self):
+    def delete(self):  # type: ignore[no-untyped-def]
         for obj in self.all():
             obj.delete()
 
 
 class DefaultManager(models.Manager):
-    def get_queryset(self):
+    def get_queryset(self) -> ProtectiveQueryset:
         return ProtectiveQueryset(self.model, using=self._db)
 
 
 class ActiveLiaisonManager(models.Manager):
-    def get_queryset(self):
+    def get_queryset(self) -> ProtectiveQueryset:
         return ProtectiveQueryset(self.model, using=self._db).filter(active=True)
 
 
@@ -41,7 +41,7 @@ class Meta:
         verbose_name_plural = "Liaisons"
         ordering = ["last_name", "first_name"]
 
-    def __str__(self):
+    def __str__(self) -> str:
         return "{self.first_name} {self.last_name}".format(self=self)
 
     first_name = models.CharField(max_length=15)
@@ -59,9 +59,9 @@ def __str__(self):
     # Liaisons.
     objects = ActiveLiaisonManager()
 
-    def save(self, *args, **kwargs):
+    def save(self, *args, **kwargs) -> None:
         if not self.active:
-            self.dlc_set.clear()
+            self.dlc_set.clear()  # type: ignore[attr-defined]
 
         return super(Liaison, self).save(*args, **kwargs)
 

solenoid/people/views.py

@@ -112,7 +112,7 @@ def post(self, request, *args, **kwargs):
             return self.form_invalid(form)
 
 
-class LiaisonDelete(ConditionalLoginRequiredMixin, DeleteView):
+class LiaisonDelete(ConditionalLoginRequiredMixin, DeleteView):  # type: ignore[misc]
     model = Liaison
     queryset = Liaison.objects.all()