Skip to content

Commit

Permalink
Allow missing citation fields when importing publications (#472)
Browse files Browse the repository at this point in the history
Why these changes are being introduced:
* Publications should be imported even when Solenoid can't
generate a "minimal" citation since users of Solenoid can
manually enter this missing information when editing the email
request.

How this addresses that need:
* Differentiate methods for identifying missing citation fields vs. required id fields
* Improve logging to communicate what the missing fields are (if any)
* Update method for generating citations to denote missing citation fields as "UNIDENTIFIED"
* Allow addition of records missing citation fields to database

Side effects of this change:
* Imports that previously failed due to missing citation fields
should now be successfully imported to Solenoid.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/INFRA-438
  • Loading branch information
jonavellecuerdo authored May 10, 2024
1 parent 323ff08 commit 266db61
Show file tree
Hide file tree
Showing 5 changed files with 491 additions and 445 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ target/
# pyenv
.python-version

# asdf
.tool-versions

# celery beat schedule file
celerybeat-schedule

Expand Down
Loading

0 comments on commit 266db61

Please sign in to comment.