Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code and comment readibility in the met file scripts #34

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Calebsakhtar
Copy link
Contributor

@Calebsakhtar Calebsakhtar commented Aug 26, 2024

This PR aims to improve code and comment readibility for the met file scripts. Specifically, the following was done:

  • Improved the instructions on how to run the script to the met readme
  • Added units to some relevant code variable names to help with readability
  • Improved the code comments and fixed some mistakes in them
  • Specified the imported functions from the src modules

@Calebsakhtar
Copy link
Contributor Author

@sdeastham Would you mind giving ths a quick review?

@sdeastham
Copy link
Collaborator

Thanks @Calebsakhtar ! I'll test this later this week.

@sdeastham
Copy link
Collaborator

Verified that the scripts work, the output meteorology looks reasonable and runs with APCEMM, and the comment changes are an improvement. Thanks @Calebsakhtar !

@sdeastham sdeastham merged commit 67f9541 into MIT-LAE:main Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants