Code

Added my retrospective contribution #515

Code

Closed

AmmarIbrahimTech wants to merge 160 commits intomainMIT-Emerging-Talent/ET6-practice-code-review:mainfrom retrospective_ammarMIT-Emerging-Talent/ET6-foundations-group-21:retrospective_ammarCopy head branch name to clipboard

+2,044-75

Commits

Commits on Dec 25, 2024

• Added the group constriants to collaboration folder

  AmmarIbrahimTech

  committed
  4345127

  Copy full SHA for 4345127

Commits on Dec 26, 2024

• Added Collaboration README

  Solarahamza

  committed
  7a9b819

  Copy full SHA for 7a9b819

• fixing

  Solarahamza

  committed
  79ecafd

  Copy full SHA for 79ecafd

• other md fixes

  Solarahamza

  committed
  f239795

  Copy full SHA for f239795

Commits on Dec 27, 2024

• Describe what you changed

  nourana819

  committed
  c7b01fd

  Copy full SHA for c7b01fd

• Merge pull request #8 from MIT-Emerging-Talent/Readme

  Show description for 8e1107d
  Fikre-Mamo

  authored
  8e1107d

  Copy full SHA for 8e1107d

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  59d3110

  Copy full SHA for 59d3110

• Merge branch 'main' into constraints

  Fikre-Mamo

  committed
  82f3fb4

  Copy full SHA for 82f3fb4

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  2ce302c

  Copy full SHA for 2ce302c

• Merge branch 'main' into Group-Norms

  Fikre-Mamo

  committed
  7864929

  Copy full SHA for 7864929

• Merge branch 'Group-Norms' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-21 into Group-Norms

  Fikre-Mamo

  committed
  db88bbc

  Copy full SHA for db88bbc

Commits on Dec 28, 2024

• first commit learning objectives

  Solarahamza

  committed
  3a1ef2d

  Copy full SHA for 3a1ef2d

• fixing md linting

  Solarahamza

  committed
  bd70404

  Copy full SHA for bd70404

Commits on Dec 29, 2024

• 3mmar@AmmarOsman MINGW64 ~/Deliverables_MIT/ET6-foundations-group-21 (local_constraints)

  Show description for 8871d7f
  AmmarIbrahimTech

  committed
  8871d7f

  Copy full SHA for 8871d7f

• Edit file to meet line length rule and add Ammar's learning goals

  AmmarIbrahimTech

  committed
  42f28cb

  Copy full SHA for 42f28cb

• Edited some lines that still break line length rule

  AmmarIbrahimTech

  committed
  47cd4e2

  Copy full SHA for 47cd4e2

• edited line 63 in learning goals file

  AmmarIbrahimTech

  committed
  e535c02

  Copy full SHA for e535c02

• Merge pull request #12 from MIT-Emerging-Talent/constraints

  Show description for 9afe53d
  omerdafaalla

  authored
  9afe53d

  Copy full SHA for 9afe53d

Commits on Dec 31, 2024

• Merge branch 'main' into Setting-learning-objectives

  Fikre-Mamo

  authored
  ee3f031

  Copy full SHA for ee3f031

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  35ff7b8

  Copy full SHA for 35ff7b8

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  ddcd030

  Copy full SHA for ddcd030

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  9cab6d9

  Copy full SHA for 9cab6d9

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  8f2c6fe

  Copy full SHA for 8f2c6fe

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  68a46ab

  Copy full SHA for 68a46ab

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  cb4911b

  Copy full SHA for cb4911b

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  4af3176

  Copy full SHA for 4af3176

Commits on Jan 1, 2025

• update and fix the ci and markdown errors

  Fikre-Mamo

  committed
  54aecc9

  Copy full SHA for 54aecc9

• Merge remote-tracking branch 'origin/Setting-learning-objectives' into CI-and-markdown

  Fikre-Mamo

  committed
  be656c7

  Copy full SHA for be656c7

• resolve_conflicts

  AmmarIbrahimTech

  committed
  e4aa4b6

  Copy full SHA for e4aa4b6

• Merge branch 'main' into Conflict_main

  AmmarIbrahimTech

  authored
  45d024e

  Copy full SHA for 45d024e

• Merge pull request #19 from MIT-Emerging-Talent/Conflict_main

  Show description for 553ac3b
  omerdafaalla

  authored
  553ac3b

  Copy full SHA for 553ac3b

• Merge branch 'MIT-Emerging-Talent:main' into main

  AmmarIbrahimTech

  authored
  2dcccc3

  Copy full SHA for 2dcccc3

Commits on Jan 2, 2025

• created factorial calculater fuction and test files. And wrote the fuction main code

  AmmarIbrahimTech

  committed
  b84c09d

  Copy full SHA for b84c09d

Commits on Jan 3, 2025

• ATM system implementation with unit tests

  Fikre-Mamo

  committed
  3b5f86a

  Copy full SHA for 3b5f86a

• Merge branch 'ATM_Machine' of https://github.com/MIT-Emerging-Talent/ET6-foundations-group-21 into ATM_Machine

  Fikre-Mamo

  committed
  2ef8509

  Copy full SHA for 2ef8509

• ATM machine

  

  fikre

  committed
  c1f5169

  Copy full SHA for c1f5169

• Update atm_test.py

  Show description for e2705b1
  Fikre-Mamo

  authored
  e2705b1

  Copy full SHA for e2705b1

• Merge pull request #23 from MIT-Emerging-Talent/ATM_Machine

  Show description for 4c85034
  Nouranaia

  authored
  4c85034

  Copy full SHA for 4c85034

Commits on Jan 4, 2025

• leap year solution and test

  Solarahamza

  committed
  05cc7aa

  Copy full SHA for 05cc7aa

• Merge branch 'leap_year' of github.com:MIT-Emerging-Talent/ET6-foundations-group-21 into local_leap_year

  Solarahamza

  committed
  387b24b

  Copy full SHA for 387b24b

• added two solutions and thier tests

  Tahershaba

  committed
  50b527a

  Copy full SHA for 50b527a

• odd or even file and test

  Solarahamza

  committed
  84180bf

  Copy full SHA for 84180bf

• deleted some files

  Solarahamza

  committed
  6642ab9

  Copy full SHA for 6642ab9

• new edits

  Solarahamza

  committed
  42a7180

  Copy full SHA for 42a7180

• created a function that calculates numbers factorail and created test for the function

  AmmarIbrahimTech

  committed
  c71d188

  Copy full SHA for c71d188

• merged tha main GitHub branch into my local branch

  AmmarIbrahimTech

  committed
  f5870d6

  Copy full SHA for f5870d6

• Merge pull request #29 from MIT-Emerging-Talent/factorial_calc

  Show description for 8d7ce5c
  omerdafaalla

  authored
  8d7ce5c

  Copy full SHA for 8d7ce5c

• fixed test

  Solarahamza

  committed
  0274f4e

  Copy full SHA for 0274f4e

• Update 0_repository_setup.md

  Fikre-Mamo

  authored
  ca65f3d

  Copy full SHA for ca65f3d

• Update ci-checks.yml

  Fikre-Mamo

  authored
  6213fe8

  Copy full SHA for 6213fe8

• final changes

  Solarahamza

  committed
  24f0708

  Copy full SHA for 24f0708

• final changes

  Solarahamza

  committed
  dd167a1

  Copy full SHA for dd167a1

• finals

  Solarahamza

  committed
  4e78d27

  Copy full SHA for 4e78d27

• update group norms

  Fikre-Mamo

  committed
  19fd450

  Copy full SHA for 19fd450

• Update atm_test.py

  Show description for 88ee518
  Fikre-Mamo

  authored
  88ee518

  Copy full SHA for 88ee518

Commits on Jan 5, 2025

• created the empty function and test files

  AmmarIbrahimTech

  committed
  fd79052

  Copy full SHA for fd79052

• created a function that convartes fahrenheit to kelvin and 6 unittests for it

  AmmarIbrahimTech

  committed
  6329616

  Copy full SHA for 6329616

• Merge pull request #39 from MIT-Emerging-Talent/fahrenheit_to_kelvin

  Show description for 78e33cf
  Nouranaia

  authored
  78e33cf

  Copy full SHA for 78e33cf

• Merge pull request #37 from MIT-Emerging-Talent/Fikre-Mamo-patch-5

  Show description for 1dc4e1b
  Nouranaia

  authored
  1dc4e1b

  Copy full SHA for 1dc4e1b

• Merge pull request #38 from MIT-Emerging-Talent/Group-Norms

  Show description for 3fee007
  Nouranaia

  authored
  3fee007

  Copy full SHA for 3fee007

• Added convert decimal to binary solution and the test

  Tahershaba

  committed
  4f498c1

  Copy full SHA for 4f498c1

• Merge pull request #40 from MIT-Emerging-Talent/main

  Show description for 1ac375e
  Fikre-Mamo

  authored
  1ac375e

  Copy full SHA for 1ac375e

• convert to title case

  nourana819

  committed
  d384fd2

  Copy full SHA for d384fd2

• updated file to match the checklist

  nourana819

  committed
  d96cd65

  Copy full SHA for d96cd65

• update to pass py formating CI

  nourana819

  committed
  b614bb3

  Copy full SHA for b614bb3

• new update to pass py formating CI

  nourana819

  committed
  8cd3d4c

  Copy full SHA for 8cd3d4c

Commits on Jan 6, 2025

• update to pass py formating CI

  nourana819

  committed
  2c877eb

  Copy full SHA for 2c877eb

• Merge pull request #42 from MIT-Emerging-Talent/Title-Case

  Show description for e3951c7
  Fikre-Mamo

  authored
  e3951c7

  Copy full SHA for e3951c7

• fixing

  Solarahamza

  committed
  e120e03

  Copy full SHA for e120e03

• fixingg

  Solarahamza

  committed
  108cf95

  Copy full SHA for 108cf95

• Added a merge_two_sorted_lists solution and its Unittests

  KimaciaJnr

  committed
  7baca0a

  Copy full SHA for 7baca0a

• Add merge_two_sorted_lists function and its Unittests

  KimaciaJnr

  committed
  937e296

  Copy full SHA for 937e296

• Added convert_int_to_roman function and its Unittests

  KimaciaJnr

  committed
  ec866a2

  Copy full SHA for ec866a2

• Merge pull request #32 from MIT-Emerging-Talent/odd_or_even

  Show description for 6921a10
  Fikre-Mamo

  authored
  6921a10

  Copy full SHA for 6921a10

• Merge pull request #31 from MIT-Emerging-Talent/leap_year

  Show description for 1ff3ba4
  Fikre-Mamo

  authored
  1ff3ba4

  Copy full SHA for 1ff3ba4

• Update the atm and test_atm

  

  fikre

  committed
  dd16e78

  Copy full SHA for dd16e78

• Fix formatting issues

  Tahershaba

  committed
  7f23ddd

  Copy full SHA for 7f23ddd

• fixing py_test Error

  

  fikre

  committed
  25d1579

  Copy full SHA for 25d1579

• Add budget calculation

  omerdafaalla

  committed
  e2b0cab

  Copy full SHA for e2b0cab

• Add test cases for budget calculation

  omerdafaalla

  committed
  6bb8c65

  Copy full SHA for 6bb8c65

• Update test_atm.py

  Show description for fe1fe68
  Fikre-Mamo

  authored
  fe1fe68

  Copy full SHA for fe1fe68

Commits on Jan 7, 2025

• Fix error

  omerdafaalla

  committed
  6401bac

  Copy full SHA for 6401bac

• update tests

  omerdafaalla

  committed
  5f22c23

  Copy full SHA for 5f22c23

• Deleted the second solution

  KimaciaJnr

  committed
  bf08713

  Copy full SHA for bf08713

• Added convert_int_to_roman function and its unittest

  KimaciaJnr

  committed
  5cd0573

  Copy full SHA for 5cd0573

• calculates body mass index(bmi)

  Collins331

  committed
  1570e83

  Copy full SHA for 1570e83

• update user name

  collyns-linc

  committed
  918c8bb

  Copy full SHA for 918c8bb

• Add solutions/distance.py

  omerdafaalla

  committed
  43d247a

  Copy full SHA for 43d247a

• a program that count words in a text

  collyns-linc

  committed
  3ccb6bb

  Copy full SHA for 3ccb6bb

• fix failing doctests and unittest

  collyns-linc

  committed
  3ac5eb8

  Copy full SHA for 3ac5eb8

• add documentation

  collyns-linc

  committed
  654f292

  Copy full SHA for 654f292

• add edge case tests

  collyns-linc

  committed
  ed26c4d

  Copy full SHA for ed26c4d

• Update number_guessing.py

  Fikre-Mamo

  authored
  5011185

  Copy full SHA for 5011185

• Update test_number_guessing.py

  Show description for e67b3aa
  Fikre-Mamo

  authored
  e67b3aa

  Copy full SHA for e67b3aa

• Update test_number_guessing.py

  Fikre-Mamo

  authored
  9469ac2

  Copy full SHA for 9469ac2

• Update test_number_guessing.py

  Fikre-Mamo

  authored
  06376b5

  Copy full SHA for 06376b5

• Add update solutions and docstring,defensive assertion to tests

  omerdafaalla

  committed
  f054dc9

  Copy full SHA for f054dc9

Commits on Jan 8, 2025

• Counts the number of vowels in a string.

  nourana819

  committed
  6ef1680

  Copy full SHA for 6ef1680

• test updated

  nourana819

  committed
  a40909a

  Copy full SHA for a40909a

• updated to pass CI checks

  nourana819

  committed
  d3181ac

  Copy full SHA for d3181ac

• Merge pull request #58 from MIT-Emerging-Talent/word-counter

  Show description for d0852e9
  Solarahamza

  authored
  d0852e9

  Copy full SHA for d0852e9

• Merge pull request #55 from MIT-Emerging-Talent/distance

  Show description for 35dfc64
  Solarahamza

  authored
  35dfc64

  Copy full SHA for 35dfc64

• Corrected highlighted issues in the merge_two_sorted_lists function and its unittests

  KimaciaJnr

  committed
  51c302e

  Copy full SHA for 51c302e

• Updated import statement

  KimaciaJnr

  committed
  9fda9a4

  Copy full SHA for 9fda9a4

• Merge pull request #59 from MIT-Emerging-Talent/count_vowels

  Show description for 0fc29af
  Nouranaia

  authored
  0fc29af

  Copy full SHA for 0fc29af

• Merge pull request #51 from MIT-Emerging-Talent/merge_two_sorted_lists

  Show description for f4491f1
  Fikre-Mamo

  authored
  f4491f1

  Copy full SHA for f4491f1

• Merge pull request #53 from MIT-Emerging-Talent/number_guessing

  Show description for 7b732ee
  Nouranaia

  authored
  7b732ee

  Copy full SHA for 7b732ee

• Add prisoners_dilemma

  omerdafaalla

  committed
  97b4645

  Copy full SHA for 97b4645

• Add test_prisoners_dilemma

  omerdafaalla

  committed
  163d007

  Copy full SHA for 163d007

Commits on Jan 9, 2025

• Resolve conflicts

  KimaciaJnr

  committed
  02e38c0

  Copy full SHA for 02e38c0

• a program that count words in a text

  

  collyns-linc

  authored and

  fikre

  committed
  5ee431d

  Copy full SHA for 5ee431d

• fix failing doctests and unittest

  

  collyns-linc

  authored and

  fikre

  committed
  94b949f

  Copy full SHA for 94b949f

• add documentation

  

  collyns-linc

  authored and

  fikre

  committed
  f85a248

  Copy full SHA for f85a248

• add edge case tests

  

  collyns-linc

  authored and

  fikre

  committed
  6c754fd

  Copy full SHA for 6c754fd

• Add budget calculation

  

  omerdafaalla

  authored and

  fikre

  committed
  bf03683

  Copy full SHA for bf03683

• Add test cases for budget calculation

  

  omerdafaalla

  authored and

  fikre

  committed
  4b911e3

  Copy full SHA for 4b911e3

• Fix error

  

  omerdafaalla

  authored and

  fikre

  committed
  18adbfb

  Copy full SHA for 18adbfb

• update tests

  

  omerdafaalla

  authored and

  fikre

  committed
  4d3f4e8

  Copy full SHA for 4d3f4e8

• Add solutions/distance.py

  

  omerdafaalla

  authored and

  fikre

  committed
  b37c78c

  Copy full SHA for b37c78c

• Add update solutions and docstring,defensive assertion to tests

  

  omerdafaalla

  authored and

  fikre

  committed
  dd314c6

  Copy full SHA for dd314c6

• Counts the number of vowels in a string.

  

  nourana819

  authored and

  fikre

  committed
  db1000c

  Copy full SHA for db1000c

• test updated

  

  nourana819

  authored and

  fikre

  committed
  3930118

  Copy full SHA for 3930118

• updated to pass CI checks

  

  nourana819

  authored and

  fikre

  committed
  ba47bd1

  Copy full SHA for ba47bd1

• Add merge_two_sorted_lists function and its Unittests

  

  KimaciaJnr

  authored and

  fikre

  committed
  9083651

  Copy full SHA for 9083651

• Added convert_int_to_roman function and its Unittests

  

  KimaciaJnr

  authored and

  fikre

  committed
  067177b

  Copy full SHA for 067177b

• Deleted the second solution

  

  KimaciaJnr

  authored and

  fikre

  committed
  f0d98a3

  Copy full SHA for f0d98a3

• Corrected highlighted issues in the merge_two_sorted_lists function and its unittests

  

  KimaciaJnr

  authored and

  fikre

  committed
  db670a2

  Copy full SHA for db670a2

• Updated import statement

  

  KimaciaJnr

  authored and

  fikre

  committed
  a59569b

  Copy full SHA for a59569b

• fixing py_test Error

  

  fikre

  committed
  40207da

  Copy full SHA for 40207da

• Update number_guessing.py

  

  Fikre-Mamo

  authored and

  fikre

  committed
  a8bdc76

  Copy full SHA for a8bdc76

• Update test_number_guessing.py

  Show description for 19b2449
  

  Fikre-Mamo

  authored and

  fikre

  committed
  19b2449

  Copy full SHA for 19b2449

• Update test_number_guessing.py

  

  Fikre-Mamo

  authored and

  fikre

  committed
  32c0f82

  Copy full SHA for 32c0f82

• Update test_number_guessing.py

  

  Fikre-Mamo

  authored and

  fikre

  committed
  375c852

  Copy full SHA for 375c852

• update the atm, test_atm, fix all issus and add docstrings

  

  fikre

  committed
  bbc580c

  Copy full SHA for bbc580c

• Merge pull request #47 from MIT-Emerging-Talent/atm

  Show description for ddb56a8
  collyns-linc

  authored
  ddb56a8

  Copy full SHA for ddb56a8

Commits on Jan 10, 2025

• Merge branch 'main' into convert_int_to_roman

  KimaciaJnr

  authored
  ef81a9f

  Copy full SHA for ef81a9f

• Added recomended corrections

  KimaciaJnr

  committed
  fcffbc1

  Copy full SHA for fcffbc1

• Update file name

  KimaciaJnr

  committed
  f490386

  Copy full SHA for f490386

• Update

  KimaciaJnr

  committed
  e22ccfa

  Copy full SHA for e22ccfa

• Merge branch 'convert_int_to_roman'

  KimaciaJnr

  committed
  7a70694

  Copy full SHA for 7a70694

• add my learning goals

  collyns-linc

  committed
  24caa1d

  Copy full SHA for 24caa1d

• update learning goals

  collyns-linc

  committed
  9dacb56

  Copy full SHA for 9dacb56

• Merge pull request #56 from MIT-Emerging-Talent/body-mass-index

  Show description for cb3f2cf
  omerdafaalla

  authored
  cb3f2cf

  Copy full SHA for cb3f2cf

• fix assertion error

  collyns-linc

  committed
  c18b6db

  Copy full SHA for c18b6db

• update calculte_bmi.py file

  collyns-linc

  committed
  33e60e8

  Copy full SHA for 33e60e8

• remove function call

  collyns-linc

  committed
  953e04a

  Copy full SHA for 953e04a

• fix ruff formating

  collyns-linc

  committed
  2ef21d8

  Copy full SHA for 2ef21d8

• Merge pull request #60 from MIT-Emerging-Talent/game_theory

  Show description for 73f5cb4
  Fikre-Mamo

  authored
  73f5cb4

  Copy full SHA for 73f5cb4

Commits on Jan 11, 2025

• Merge pull request #63 from MIT-Emerging-Talent/body-mass-index

  Show description for e5ebc8f
  Nouranaia

  authored
  e5ebc8f

  Copy full SHA for e5ebc8f

• Update convert_int_to_roman.py

  Show description for d07e09d
  KimaciaJnr

  authored
  d07e09d

  Copy full SHA for d07e09d

• Merge pull request #45 from MIT-Emerging-Talent/convert_decimal_binary

  Show description for cdb0ca9
  Tahershaba

  authored
  cdb0ca9

  Copy full SHA for cdb0ca9

• added retrospective

  Solarahamza

  committed
  cc1adfa

  Copy full SHA for cc1adfa

• communication file

  Solarahamza

  committed
  05de035

  Copy full SHA for 05de035

• Merge pull request #62 from MIT-Emerging-Talent/learning_goals

  Show description for 17e6dce
  Fikre-Mamo

  authored
  17e6dce

  Copy full SHA for 17e6dce

• Merge pull request #67 from MIT-Emerging-Talent/communication

  Show description for ffa46e4
  Fikre-Mamo

  authored
  ffa46e4

  Copy full SHA for ffa46e4

• Merge pull request #66 from MIT-Emerging-Talent/retrospective

  Show description for 44f77b0
  Fikre-Mamo

  authored
  44f77b0

  Copy full SHA for 44f77b0

Commits on Jan 12, 2025

• Merge pull request #52 from MIT-Emerging-Talent/convert_int_to_roman

  Show description for 177fbd3
  AmmarIbrahimTech

  authored
  177fbd3

  Copy full SHA for 177fbd3

• wrong path to give CI error (import failure)

  AmmarIbrahimTech

  committed
  eddb2c2

  Copy full SHA for eddb2c2

• fixed the wrong path, to check the CIs

  AmmarIbrahimTech

  committed
  b2cf361

  Copy full SHA for b2cf361

• added my contribution to retrospective file

  AmmarIbrahimTech

  committed
  2a3fbb9

  Copy full SHA for 2a3fbb9