Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palindrome solution #447

Open
wants to merge 152 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
152 commits
Select commit Hold shift + click to select a range
4345127
Added the group constriants to collaboration folder
AmmarIbrahimTech Dec 25, 2024
7a9b819
Added Collaboration README
Solarahamza Dec 26, 2024
79ecafd
fixing
Solarahamza Dec 26, 2024
f239795
other md fixes
Solarahamza Dec 26, 2024
c7b01fd
Describe what you changed
nourana819 Dec 27, 2024
8e1107d
Merge pull request #8 from MIT-Emerging-Talent/Readme
Fikre-Mamo Dec 27, 2024
59d3110
Update 0_repository_setup.md
Fikre-Mamo Dec 27, 2024
82f3fb4
Merge branch 'main' into constraints
Fikre-Mamo Dec 27, 2024
2ce302c
Update 0_repository_setup.md
Fikre-Mamo Dec 27, 2024
7864929
Merge branch 'main' into Group-Norms
Fikre-Mamo Dec 27, 2024
db88bbc
Merge branch 'Group-Norms' of https://github.com/MIT-Emerging-Talent/…
Fikre-Mamo Dec 27, 2024
3a1ef2d
first commit learning objectives
Solarahamza Dec 28, 2024
bd70404
fixing md linting
Solarahamza Dec 28, 2024
8871d7f
3mmar@AmmarOsman MINGW64 ~/Deliverables_MIT/ET6-foundations-group-21 …
AmmarIbrahimTech Dec 29, 2024
42f28cb
Edit file to meet line length rule and add Ammar's learning goals
AmmarIbrahimTech Dec 29, 2024
47cd4e2
Edited some lines that still break line length rule
AmmarIbrahimTech Dec 29, 2024
e535c02
edited line 63 in learning goals file
AmmarIbrahimTech Dec 29, 2024
9afe53d
Merge pull request #12 from MIT-Emerging-Talent/constraints
omerdafaalla Dec 29, 2024
ee3f031
Merge branch 'main' into Setting-learning-objectives
Fikre-Mamo Dec 31, 2024
35ff7b8
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
ddcd030
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
9cab6d9
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
8f2c6fe
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
68a46ab
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
cb4911b
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
4af3176
Update 0_repository_setup.md
Fikre-Mamo Dec 31, 2024
54aecc9
update and fix the ci and markdown errors
Fikre-Mamo Jan 1, 2025
be656c7
Merge remote-tracking branch 'origin/Setting-learning-objectives' int…
Fikre-Mamo Jan 1, 2025
e4aa4b6
resolve_conflicts
AmmarIbrahimTech Jan 1, 2025
45d024e
Merge branch 'main' into Conflict_main
AmmarIbrahimTech Jan 1, 2025
553ac3b
Merge pull request #19 from MIT-Emerging-Talent/Conflict_main
omerdafaalla Jan 1, 2025
2dcccc3
Merge branch 'MIT-Emerging-Talent:main' into main
AmmarIbrahimTech Jan 1, 2025
b84c09d
created factorial calculater fuction and test files. And wrote the fu…
AmmarIbrahimTech Jan 2, 2025
3b5f86a
ATM system implementation with unit tests
Fikre-Mamo Jan 3, 2025
2ef8509
Merge branch 'ATM_Machine' of https://github.com/MIT-Emerging-Talent/…
Fikre-Mamo Jan 3, 2025
c1f5169
ATM machine
Jan 3, 2025
e2705b1
Update atm_test.py
Fikre-Mamo Jan 3, 2025
4c85034
Merge pull request #23 from MIT-Emerging-Talent/ATM_Machine
Nouranaia Jan 3, 2025
05cc7aa
leap year solution and test
Solarahamza Jan 4, 2025
387b24b
Merge branch 'leap_year' of github.com:MIT-Emerging-Talent/ET6-founda…
Solarahamza Jan 4, 2025
50b527a
added two solutions and thier tests
Tahershaba Jan 4, 2025
84180bf
odd or even file and test
Solarahamza Jan 4, 2025
6642ab9
deleted some files
Solarahamza Jan 4, 2025
42a7180
new edits
Solarahamza Jan 4, 2025
c71d188
created a function that calculates numbers factorail and created test…
AmmarIbrahimTech Jan 4, 2025
f5870d6
merged tha main GitHub branch into my local branch
AmmarIbrahimTech Jan 4, 2025
8d7ce5c
Merge pull request #29 from MIT-Emerging-Talent/factorial_calc
omerdafaalla Jan 4, 2025
0274f4e
fixed test
Solarahamza Jan 4, 2025
ca65f3d
Update 0_repository_setup.md
Fikre-Mamo Jan 4, 2025
6213fe8
Update ci-checks.yml
Fikre-Mamo Jan 4, 2025
24f0708
final changes
Solarahamza Jan 4, 2025
dd167a1
final changes
Solarahamza Jan 4, 2025
4e78d27
finals
Solarahamza Jan 4, 2025
19fd450
update group norms
Fikre-Mamo Jan 4, 2025
88ee518
Update atm_test.py
Fikre-Mamo Jan 4, 2025
fd79052
created the empty function and test files
AmmarIbrahimTech Jan 5, 2025
6329616
created a function that convartes fahrenheit to kelvin and 6 unittest…
AmmarIbrahimTech Jan 5, 2025
78e33cf
Merge pull request #39 from MIT-Emerging-Talent/fahrenheit_to_kelvin
Nouranaia Jan 5, 2025
1dc4e1b
Merge pull request #37 from MIT-Emerging-Talent/Fikre-Mamo-patch-5
Nouranaia Jan 5, 2025
3fee007
Merge pull request #38 from MIT-Emerging-Talent/Group-Norms
Nouranaia Jan 5, 2025
4f498c1
Added convert decimal to binary solution and the test
Tahershaba Jan 5, 2025
1ac375e
Merge pull request #40 from MIT-Emerging-Talent/main
Fikre-Mamo Jan 5, 2025
d384fd2
convert to title case
nourana819 Jan 5, 2025
d96cd65
updated file to match the checklist
nourana819 Jan 5, 2025
b614bb3
update to pass py formating CI
nourana819 Jan 5, 2025
8cd3d4c
new update to pass py formating CI
nourana819 Jan 5, 2025
2c877eb
update to pass py formating CI
nourana819 Jan 6, 2025
e3951c7
Merge pull request #42 from MIT-Emerging-Talent/Title-Case
Fikre-Mamo Jan 6, 2025
e120e03
fixing
Solarahamza Jan 6, 2025
108cf95
fixingg
Solarahamza Jan 6, 2025
937e296
Add merge_two_sorted_lists function and its Unittests
KimaciaJnr Jan 6, 2025
ec866a2
Added convert_int_to_roman function and its Unittests
KimaciaJnr Jan 6, 2025
6921a10
Merge pull request #32 from MIT-Emerging-Talent/odd_or_even
Fikre-Mamo Jan 6, 2025
1ff3ba4
Merge pull request #31 from MIT-Emerging-Talent/leap_year
Fikre-Mamo Jan 6, 2025
dd16e78
Update the atm and test_atm
Jan 6, 2025
7f23ddd
Fix formatting issues
Tahershaba Jan 6, 2025
25d1579
fixing py_test Error
Jan 6, 2025
e2b0cab
Add budget calculation
omerdafaalla Jan 6, 2025
6bb8c65
Add test cases for budget calculation
omerdafaalla Jan 6, 2025
fe1fe68
Update test_atm.py
Fikre-Mamo Jan 6, 2025
6401bac
Fix error
omerdafaalla Jan 7, 2025
5f22c23
update tests
omerdafaalla Jan 7, 2025
bf08713
Deleted the second solution
KimaciaJnr Jan 7, 2025
1570e83
calculates body mass index(bmi)
Collins331 Jan 7, 2025
918c8bb
update user name
collyns-linc Jan 7, 2025
43d247a
Add solutions/distance.py
omerdafaalla Jan 7, 2025
3ccb6bb
a program that count words in a text
collyns-linc Jan 7, 2025
3ac5eb8
fix failing doctests and unittest
collyns-linc Jan 7, 2025
654f292
add documentation
collyns-linc Jan 7, 2025
ed26c4d
add edge case tests
collyns-linc Jan 7, 2025
5011185
Update number_guessing.py
Fikre-Mamo Jan 7, 2025
e67b3aa
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
9469ac2
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
06376b5
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
f054dc9
Add update solutions and docstring,defensive assertion to tests
omerdafaalla Jan 7, 2025
6ef1680
Counts the number of vowels in a string.
nourana819 Jan 8, 2025
a40909a
test updated
nourana819 Jan 8, 2025
d3181ac
updated to pass CI checks
nourana819 Jan 8, 2025
d0852e9
Merge pull request #58 from MIT-Emerging-Talent/word-counter
Solarahamza Jan 8, 2025
35dfc64
Merge pull request #55 from MIT-Emerging-Talent/distance
Solarahamza Jan 8, 2025
51c302e
Corrected highlighted issues in the merge_two_sorted_lists function a…
KimaciaJnr Jan 8, 2025
9fda9a4
Updated import statement
KimaciaJnr Jan 8, 2025
0fc29af
Merge pull request #59 from MIT-Emerging-Talent/count_vowels
Nouranaia Jan 8, 2025
f4491f1
Merge pull request #51 from MIT-Emerging-Talent/merge_two_sorted_lists
Fikre-Mamo Jan 8, 2025
7b732ee
Merge pull request #53 from MIT-Emerging-Talent/number_guessing
Nouranaia Jan 8, 2025
97b4645
Add prisoners_dilemma
omerdafaalla Jan 8, 2025
163d007
Add test_prisoners_dilemma
omerdafaalla Jan 8, 2025
5ee431d
a program that count words in a text
collyns-linc Jan 7, 2025
94b949f
fix failing doctests and unittest
collyns-linc Jan 7, 2025
f85a248
add documentation
collyns-linc Jan 7, 2025
6c754fd
add edge case tests
collyns-linc Jan 7, 2025
bf03683
Add budget calculation
omerdafaalla Jan 6, 2025
4b911e3
Add test cases for budget calculation
omerdafaalla Jan 6, 2025
18adbfb
Fix error
omerdafaalla Jan 7, 2025
4d3f4e8
update tests
omerdafaalla Jan 7, 2025
b37c78c
Add solutions/distance.py
omerdafaalla Jan 7, 2025
dd314c6
Add update solutions and docstring,defensive assertion to tests
omerdafaalla Jan 7, 2025
db1000c
Counts the number of vowels in a string.
nourana819 Jan 8, 2025
3930118
test updated
nourana819 Jan 8, 2025
ba47bd1
updated to pass CI checks
nourana819 Jan 8, 2025
9083651
Add merge_two_sorted_lists function and its Unittests
KimaciaJnr Jan 6, 2025
067177b
Added convert_int_to_roman function and its Unittests
KimaciaJnr Jan 6, 2025
f0d98a3
Deleted the second solution
KimaciaJnr Jan 7, 2025
db670a2
Corrected highlighted issues in the merge_two_sorted_lists function a…
KimaciaJnr Jan 8, 2025
a59569b
Updated import statement
KimaciaJnr Jan 8, 2025
40207da
fixing py_test Error
Jan 6, 2025
a8bdc76
Update number_guessing.py
Fikre-Mamo Jan 7, 2025
19b2449
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
32c0f82
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
375c852
Update test_number_guessing.py
Fikre-Mamo Jan 7, 2025
bbc580c
update the atm, test_atm, fix all issus and add docstrings
Jan 9, 2025
ddb56a8
Merge pull request #47 from MIT-Emerging-Talent/atm
collyns-linc Jan 9, 2025
cb3f2cf
Merge pull request #56 from MIT-Emerging-Talent/body-mass-index
omerdafaalla Jan 10, 2025
c18b6db
fix assertion error
collyns-linc Jan 10, 2025
33e60e8
update calculte_bmi.py file
collyns-linc Jan 10, 2025
953e04a
remove function call
collyns-linc Jan 10, 2025
2ef21d8
fix ruff formating
collyns-linc Jan 10, 2025
73f5cb4
Merge pull request #60 from MIT-Emerging-Talent/game_theory
Fikre-Mamo Jan 10, 2025
e5ebc8f
Merge pull request #63 from MIT-Emerging-Talent/body-mass-index
Nouranaia Jan 11, 2025
cdb0ca9
Merge pull request #45 from MIT-Emerging-Talent/convert_decimal_binary
Tahershaba Jan 11, 2025
9c85ea8
Add solutions and test files for Palindrome number and Remove Duplica…
njeridorcaswanja Jan 11, 2025
9a5ae81
docs: add docstring and fix syntax errors in palindrome solution
njeridorcaswanja Jan 12, 2025
e8465d1
Fix import issue in Palindrome_Number.py solution
njeridorcaswanja Jan 12, 2025
b1dcd79
Fix import issue in test_Palindrome_Number.py
njeridorcaswanja Jan 12, 2025
6eabd73
Fix import and formatting issues for Remove_Duplicates_from_sorted_Array
njeridorcaswanja Jan 13, 2025
eb9589a
Add new Palindrome_Number.py and fix tests
njeridorcaswanja Jan 13, 2025
5b75427
Fix formatting and update logic for Palindrome_Number.py and add test…
njeridorcaswanja Jan 13, 2025
08f233c
Fix import issue and update logic for Palindrome Number function
njeridorcaswanja Jan 13, 2025
2320be8
Fix import issue and update logic for Remove Duplicates function
njeridorcaswanja Jan 13, 2025
032b029
Resolve merge conflict in test_palindrome_number.py
njeridorcaswanja Jan 13, 2025
6e789d4
Fix test_palindrome_number.py
njeridorcaswanja Jan 13, 2025
016f5cd
fix import issues
njeridorcaswanja Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve_conflicts
AmmarIbrahimTech committed Jan 1, 2025
commit e4aa4b6ec2608abce84ac33ed1e64f12241c307b
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/help_wanted.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
---
name: help wanted
about: >
about: >
A template issue for when you're blocked on certain lines of code.
This template has many sections to get you thinking about your problem, you don't need to fill all of them.
This template has many sections to get you thinking about your problem,
you don't need to fill all of them.
labels: "help wanted"

---

<!--
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/meeting_agenda.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
---
name: meeting agenda
about: A template issue for planning meetings
title: "Agenda: __"
title: "Agenda: \_\_"
labels: agenda
---


<!-- Make your issue easy to find:

- milestone: any milestones you will be addressing
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/new_challenge.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
---
name: new challenge
about: >
A template issue for describing a new challenge on the project board.
about: >
A template issue for describing a new challenge on the project board.
Place this issue in the TODO column of your group's project board.
title: ''
---

<!--
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/question.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: question
about: >
about: >
A template issue for topics you'd like to discuss or learn more about.
specific topics, general knowledge, it does not even need to be about code.
There are no bad questions!
3 changes: 3 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -55,6 +55,7 @@ about: A template PR for code review with a checklist
- [ ] The function's name describes it's behavior
- [ ] The function's name matches the file name
- [ ] The function has correct type annotations
- [ ] The function is not called in the function file

## Strategy

@@ -82,5 +83,7 @@ about: A template PR for code review with a checklist
- [ ] Variable names are clear and helpful
- [ ] The code follows the strategy as simply as possible
- [ ] The implementation is as simple as possible given the strategy
- [ ] There are no commented lines of code
- [ ] There are no `print` statements anywhere
- [ ] The code includes defensive assertions
- [ ] Defensive assertions include as little logic as possible
17 changes: 17 additions & 0 deletions .github/workflows/ci-checks.yml
Original file line number Diff line number Diff line change
@@ -55,9 +55,26 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: python version
run: python --version
shell: bash

- name: Check for test files
id: check_tests
run: |
test_files=$(find ./solutions/tests -type f -name "test_*.py")
if [ -n "$test_files" ]; then
echo "Found test files:"
echo "$test_files"
echo "has_tests=true" >> $GITHUB_OUTPUT
else
echo "No test files found matching pattern ./solutions/tests/test_*.py"
echo "has_tests=false" >> $GITHUB_OUTPUT
fi
shell: bash

- name: Python - Run Tests
if: steps.check_tests.outputs.has_tests == 'true'
run: python -m unittest
shell: bash
11 changes: 10 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -113,5 +113,14 @@
},

// Enable/disable update table of contents on save
"markdown.extension.toc.updateOnSave": false
"markdown.extension.toc.updateOnSave": false,

"[python]": {
"editor.defaultFormatter": "charliermarsh.ruff",
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.ruff": true,
"source.organizeImports.ruff": true
}
}
}
9 changes: 5 additions & 4 deletions collaboration/guide/0_repository_setup.md
Original file line number Diff line number Diff line change
@@ -6,15 +6,16 @@ take the time to do this correctly at the beginning.

## Setup and Share a Repository

As a team you will choose the name for your team and select
someone from your team to be the repo owner. This person will fork this
repository and configure it for collaboration:
As a team you will choose the name for your team and select someone from your
team to be the repo owner. This person will fork this repository and configure
it for collaboration:

- Public face of your repository
- Change your
[repository description](https://stackoverflow.com/questions/7757751/how-do-you-change-a-repository-description-on-github)
- Add or remove topics from your repository
- Update your main README with your group name and an initial overview of your project. (You can change this as much as you want.)
- Update your main README with your group name and an initial overview of your
project. (You can change this as much as you want.)
- Under settings in your repository select:
- _Issues_
- _Projects_
1 change: 1 addition & 0 deletions solutions/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

1 change: 1 addition & 0 deletions solutions/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@