forked from MIT-Emerging-Talent/ET6-practice-code-review
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #12 from MIT-Emerging-Talent/Group-norms
Group norms
- Loading branch information
Showing
2 changed files
with
27 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,19 +4,19 @@ on: [push, pull_request, workflow_dispatch] | |
|
||
jobs: | ||
ls_linting: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: ls-lint/[email protected] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: ls-lint/[email protected] | ||
|
||
md_formatting: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: nosborn/[email protected] | ||
with: | ||
files: . | ||
config_file: .markdownlint.yml | ||
- uses: actions/checkout@v4 | ||
- uses: nosborn/[email protected] | ||
with: | ||
files: . | ||
config_file: .markdownlint.yml | ||
|
||
py_formatting: | ||
runs-on: ubuntu-latest | ||
|
@@ -50,14 +50,20 @@ jobs: | |
- name: Python - Check Linting - pylint | ||
run: "pylint solutions tests || echo '::warning title=Pylint Error(s)::Discuss solutions and trade-offs in code review.'" | ||
shell: bash | ||
|
||
py_tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: python version | ||
run: python --version | ||
shell: bash | ||
- name: Python - Run Tests | ||
run: python -m unittest | ||
shell: bash | ||
py_tests: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Check for Non-Markdown Changes | ||
run: | | ||
if ! git diff --name-only HEAD^1 | grep -E -v '\.md$'; then | ||
echo "Only Markdown files changed. Skipping tests." | ||
exit 0 | ||
fi | ||
shell: bash | ||
- name: python version | ||
run: python --version | ||
shell: bash | ||
- name: Python - Run Tests | ||
run: python -m unittest | ||
shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ | |
you can follow this procedure to create a local branch. | ||
|
||
1 | ||
updating py_test |