Add dictionary merge solution and related test

[Frank2446-dotcom]

---

name: solution review
about: A template PR for code review with a checklist

Behavior

Files

• The file name describes the function's behavior
• There is a module docstring in the function file
• The test file's name matches the function file name -
  /tests/test_file_name.py
• There is a module docstring in the tests file

Unit Tests

• The test class has a helpful name in PascalCase
• The test class has a docstring
• Every unit test has
  • A helpful name
  • A clear docstring
  • Only one assertion
  • There is no logic in the unit test
• All tests pass
• There are tests for defensive assertions
• There are tests for boundary cases

Function Docstring

• The function's behavior is described
• The function's arguments are described:
  • Type
  • Purpose
  • Other assumptions (eg. if it's a number, what's the expected range?)
• The return value is described
  • Type
  • Other assumptions are documented
• The defensive assertions are documented using Raises:
  • Each assumption about an argument is checked with an assertion
  • Each assertion checks for only one assumption about the argument
• Include 3 or more (passing!) doctests

The Function

• The function's name describes it's behavior
• The function's name matches the file name
• The function has correct type annotations
• The function is not called in the function file

Strategy

Do's

• Variable names help to understand the strategy
• Any comments are clear and describe the strategy
• Lines of code are spaced to help show different stages of the strategy

Don'ts

• The function's strategy is not described in the documentation
• Comments explain the strategy, not the implementation
• The function does not have more comments than code
  • If it does, consider finding a new strategy or a simpler implementation

Implementation

• The code passes the formatting checks
• The code passes all Ruff linting checks
• The code has no (reasonable) Pylint errors
  • In code review, you can decide when fixing a Pylint error is helpful and
    when it's too restricting.
• Variables are named with snake_case
• Variable names are clear and helpful
• The code follows the strategy as simply as possible
• The implementation is as simple as possible given the strategy
• There are no commented lines of code
• There are no print statements anywhere
• The code includes defensive assertions
• Defensive assertions include as little logic as possible

[TibyanKhalid]

Hey Frank, these are the stuff that were missing from the challenge and the tests file, they are the boxes that I didn’t tick in the checklist as well

[TibyanKhalid]

You should add a module docstring to the Tests file

[TibyanKhalid]

The test class should have the name in PascalCase
You should add a docstring to the test class

[TibyanKhalid]

You should add docstrings to each unit test that describes what the test is checking

[TibyanKhalid]

You should add defensive assertions tests ( Tests that focus on verifying that a function has internal checks (like assertions) to catch invalid states or inputs )

[TibyanKhalid]

You should NOT have print statements anywhere

[TibyanKhalid]

You should add more doctests ( you only have 2, there should be at least 3 )

[TibyanKhalid]

You should add defensive assertions and they should include as little logic as possible
You should document defensive assertions using Raises:

1. Each assumption about an argument must be checked with an assertion
2. Each assertion should check for only 1 assumption about the argument

[TibyanKhalid]

I can see that you added all the changes and edits required, good job!! It's ready to merge now