Adding solutions

[FKN237]

---

name: solution review
about: A template PR for code review with a checklist

Behavior

Files

• The file name describes the function's behavior
• There is a module docstring in the function file
• The test file's name matches the function file name -
  /tests/test_file_name.py
• There is a module docstring in the tests file

Unit Tests

• The test class has a helpful name in PascalCase
• The test class has a docstring
• Every unit test has
  • A helpful name
  • A clear docstring
  • Only one assertion
  • There is no logic in the unit test
• All tests pass
• There are tests for defensive assertions
• There are tests for boundary cases

Function Docstring

• The function's behavior is described
• The function's arguments are described:
  • Type
  • Purpose
  • Other assumptions (eg. if it's a number, what's the expected range?)
• The return value is described
  • Type
  • Other assumptions are documented
• The defensive assertions are documented using Raises:
  • Each assumption about an argument is checked with an assertion
  • Each assertion checks for only one assumption about the argument
• Include 3 or more (passing!) doctests

The Function

• The function's name describes it's behavior
• The function's name matches the file name
  • It's ok to have extra helper functions if necessary, like with mergesort
• The function has correct type annotations
• The function is not called at the top level of the function file
  • Recursive solutions can call the function from inside the function body

Strategy

Do's

• Variable names help to understand the strategy
• Any comments are clear and describe the strategy
• Lines of code are spaced to help show different stages of the strategy

Don'ts

• The function's strategy is not described in any docstrings or tests
• Comments explain the strategy, not the implementation
• The function does not have more comments than code
  • If it does, consider finding a new strategy or a simpler implementation

Implementation

• The code passes the formatting checks
• The code passes all Ruff linting checks
• The code has no (reasonable) Pylint errors
  • In code review, you can decide when fixing a Pylint error is helpful and
    when it's too restricting.
• Variables are named with snake_case
• Variable names are clear and helpful
• The code follows the strategy as simply as possible
• The implementation is as simple as possible given the strategy
• There are no commented lines of code
• There are no print statements anywhere
• The code includes defensive assertions
• Defensive assertions include as little logic as possible

[matopcheg]

Amazing, Nelson! You did a very good job. I did look on some checkboxes and noticed that some of them are not satisfied. If you can make some changes, it would be nice.

• You need to have 3 or more doctests in function file
• Make a module dosctring for test and function file (just write a summary docstring in the beggining of your files)
• Add defensive assertions.
• Correct type of annotations in function. For example, in count_vowels you can add def count_vowels(s: str) -> int:

If you need any help - feel free to ask me or Nagham and Salem!

[FKN237]

Amazing, Nelson! You did a very good job. I did look on some checkboxes and noticed that some of them are not satisfied. If you can make some changes, it would be nice.

• You need to have 3 or more doctests in function file
• Make a module dosctring for test and function file (just write a summary docstring in the beggining of your files)
• Add defensive assertions.
• Correct type of annotations in function. For example, in count_vowels you can add def count_vowels(s: str) -> int:

If you need any help - feel free to ask me or Nagham and Salem!

Alright 👌 thank you Matvii. I tried adding the module doctring, but when I do that, I keep having python formatting issues

[matopcheg]

Good job!