Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fibonacci Sequence Generator Challenge #148

Merged
merged 3 commits into from
Jan 12, 2025
Merged

Fibonacci Sequence Generator Challenge #148

merged 3 commits into from
Jan 12, 2025

Conversation

RandomProjects-db
Copy link

This PR introduces the Fibonacci Sequence Generator Challenge.

Changes:

fibonacci.py:

Implements the generate_fibonacci(n) function to generate the first n terms of the Fibonacci sequence.
Includes comprehensive docstrings with examples, input validation, and return details.

test_fibonacci.py:

Adds unit tests for the generate_fibonacci function.
Covers cases like n=0, n=1, large n, and invalid inputs (negative numbers, non-integer types).

The addition follows the standard challenge format, ensuring clarity and consistency. Feedback and suggestions are welcome!

Copy link

@FaisalMinawi FaisalMinawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these points and update the PR. Let me know if you need any clarification.

solutions/fibonacci.py Show resolved Hide resolved
Copy link

@FaisalMinawi FaisalMinawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@FaisalMinawi FaisalMinawi merged commit 301b108 into main Jan 12, 2025
10 checks passed
@FaisalMinawi FaisalMinawi deleted the fib branch January 12, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Fibonacci Sequence Generator Challenge
2 participants