Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integerated team constraints #42

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Integerated team constraints #42

merged 4 commits into from
Jan 11, 2025

Conversation

NoorelsalamAlmakki
Copy link

This pull request is to create the group's constraints markdown file.

Description:

According to the discussion in issue #19, this pull request integrates the group's constraints suggested by @Safiya-hash, @tosan-okome, @Hopeeid, and me.

Notice:

Review the file and make sure that:

  • Your ideas are correctly represented.
  • The code passes the ci-checks.
  • Add any necessary changes or comments.

@NoorelsalamAlmakki NoorelsalamAlmakki added the documentation Improvements or additions to documentation label Jan 6, 2025
@NoorelsalamAlmakki NoorelsalamAlmakki self-assigned this Jan 6, 2025
@NoorelsalamAlmakki NoorelsalamAlmakki linked an issue Jan 6, 2025 that may be closed by this pull request
@ndubuisia
Copy link

ndubuisia commented Jan 11, 2025

The constraints were well written and clear.

@ndubuisia ndubuisia self-requested a review January 11, 2025 03:40
@NoorelsalamAlmakki
Copy link
Author

@ndubuisia Please review the code more time and approve it if it's ready to be merged.

Copy link

@ndubuisia ndubuisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is self-explanatory and well formatted. It is ready to be merged.

@ndubuisia ndubuisia merged commit e1731ad into main Jan 11, 2025
10 checks passed
@ndubuisia ndubuisia deleted the documentation/constraints branch January 11, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To identify the group's constraints
2 participants