-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add communication plan to collaboration/communication.md #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear description
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear description
The merge-base changed after approval.
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communication plan is completed
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good documentation and description
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should firstly delete constraints and learning_goals files. and then everythings is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more attempt
The merge-base changed after approval.
Nimatallahi could you approve the review and try to merge to the main? Neither I nor Emre can do it. Even with approved review (by me not by Emre) there is notification "Review required". |
The merge-base changed after approval.
The unrelated files have been removed. |
Nima was unable to complete the merge. I’m currently looking into the issue to resolve it. |
Don't spend time. Just create a new branch and modify only this one file (communication.md). This branch looks defective. The other possible side effect is that when reverting this branch we can remove other PRs that have already been added to the main. Since today is the last date, it is better to avoid such experiments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more attempt
The merge-base changed after approval.
Should we close this pull request, or keep it open while working on the new branch? |
All conflicts have been resolved, and apart from this file, the other unrelated files in the main branch will not be affected. |
communication.md
file under the/collaboration/
folder.