Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add communication plan to collaboration/communication.md #24

Merged
merged 7 commits into from
Jan 12, 2025

Conversation

emrebiyik
Copy link

  • Adds the communication.md file under the /collaboration/ folder.
  • Outlines the communication schedule, channels, and availability for the team.
  • To define a clear communication structure and ensure team alignment.

@emrebiyik emrebiyik added the documentation Improvements or additions to documentation label Jan 4, 2025
@emrebiyik emrebiyik self-assigned this Jan 4, 2025
Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear description

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 6, 2025 12:25

The merge-base changed after approval.

Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear description

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 6, 2025 12:32

The merge-base changed after approval.

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 6, 2025 12:51

The merge-base changed after approval.

Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Communication plan is completed

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 12, 2025 11:20

The merge-base changed after approval.

NimahMasuud
NimahMasuud previously approved these changes Jan 12, 2025
Copy link

@NimahMasuud NimahMasuud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good documentation and description

@emrebiyik emrebiyik dismissed NimahMasuud’s stale review January 12, 2025 12:06

The merge-base changed after approval.

Copy link

@NimahMasuud NimahMasuud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should firstly delete constraints and learning_goals files. and then everythings is ok.

NimahMasuud
NimahMasuud previously approved these changes Jan 12, 2025
Copy link

@NimahMasuud NimahMasuud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@emrebiyik emrebiyik dismissed NimahMasuud’s stale review January 12, 2025 12:13

The merge-base changed after approval.

Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more attempt

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 12, 2025 12:24

The merge-base changed after approval.

@oleksandr-maksymikhin
Copy link

Nimatallahi could you approve the review and try to merge to the main? Neither I nor Emre can do it. Even with approved review (by me not by Emre) there is notification "Review required".

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 12, 2025 12:29

The merge-base changed after approval.

@emrebiyik
Copy link
Author

you should firstly delete constraints and learning_goals files. and then everythings is ok.

The unrelated files have been removed.

@emrebiyik
Copy link
Author

Nimatallahi could you approve the review and try to merge to the main? Neither I nor Emre can do it. Even with approved review (by me not by Emre) there is notification "Review required".

Nima was unable to complete the merge. I’m currently looking into the issue to resolve it.

@oleksandr-maksymikhin
Copy link

Don't spend time. Just create a new branch and modify only this one file (communication.md). This branch looks defective. The other possible side effect is that when reverting this branch we can remove other PRs that have already been added to the main. Since today is the last date, it is better to avoid such experiments.

Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more attempt

@emrebiyik emrebiyik dismissed oleksandr-maksymikhin’s stale review January 12, 2025 13:30

The merge-base changed after approval.

@emrebiyik
Copy link
Author

Don't spend time. Just create a new branch and modify only this one file (communication.md). This branch looks defective. The other possible side effect is that when reverting this branch we can remove other PRs that have already been added to the main. Since today is the last date, it is better to avoid such experiments.

Should we close this pull request, or keep it open while working on the new branch?

@emrebiyik
Copy link
Author

All conflicts have been resolved, and apart from this file, the other unrelated files in the main branch will not be affected.

@oleksandr-maksymikhin oleksandr-maksymikhin merged commit 45c5238 into main Jan 12, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

3 participants