Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add palindrome check #15

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Add palindrome check #15

merged 8 commits into from
Jan 6, 2025

Conversation

emrebiyik
Copy link

This pull request includes the following changes:

  1. Implemented a palindrome checker function (is_palindrome) in the solutions directory.
  2. Added corresponding unit tests in solutions/test_is_palindrome.py to ensure proper functionality and edge-case handling.
  3. Reformatted files using Ruff to meet style and formatting requirements.
  4. Renamed folders and files in the collaboration/minutes-of-meeting directory to comply with snake_case naming conventions.

Please review the changes and let me know if further improvements are needed. Thank you!

@emrebiyik emrebiyik added good first issue Good for newcomers code challenge challenge for CDS program labels Dec 31, 2024
@emrebiyik emrebiyik self-assigned this Dec 31, 2024
Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added review in comments to each file

solutions/is_palindrome.py Show resolved Hide resolved
solutions/test_is_palindrome.py Outdated Show resolved Hide resolved
solutions/tests/__init__.py Show resolved Hide resolved
@emrebiyik
Copy link
Author

The Pull Request has been updated with the latest changes. All requested modifications have been implemented in the most recent commit. Please review the updates and let me know if further changes are required.

Copy link

@oleksandr-maksymikhin oleksandr-maksymikhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the issues were resolved

@oleksandr-maksymikhin oleksandr-maksymikhin merged commit d4a8345 into main Jan 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code challenge challenge for CDS program good first issue Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

2 participants