-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Challenge 3 the tribonacci sequence #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work but some things are missing for it to be perfect :
- You forgot the READMe file
- The Function's Strategy Is Not Described in the Documentation (The current docstring briefly explains the Tribonacci sequence but doesn’t describe the iterative approach used in the function.)
- It also lacks comments that explicitly describe the iterative approach used to compute the Tribonacci sequence.
…n Raised for Invalid Inputs
…Emerging-Talent/ET6-foundations-group-04 into challenge-3-the-tribonacci-sequence
…and Author information
…Emerging-Talent/ET6-foundations-group-04 into challenge-3-the-tribonacci-sequence
@likechrisss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is now perfect.
Excellent job.
name: Challenge: The Tribonacci Sequence
about: A template PR for code review with a checklist
Behavior
The "Tribonacci sequence" challenge is a twist on the famous Fibonacci sequence, where each number is the sum of the preceding three numbers.
For example, 0, 1, 1, 2, 4, 7 …
Write a function that returns the nth number in the Tribonacci sequence.
Example
Files
/tests/test_file_name.py
Unit Tests
Function Docstring
Raises:
The Function
Strategy
Do's
Don'ts
Implementation
when it's too restricting.
print
statements anywhere