forked from MIT-Emerging-Talent/ET6-practice-code-review
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into 05-challenge-find-the-heaviest-coin
- Loading branch information
Showing
10 changed files
with
386 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| # Coding Pioneers United - Team repository | ||
|
|
||
|  | ||
|
|
||
| Welcome to our team! Our group thrives on mutual trust, open communication, and | ||
| respect, fostering a collaborative environment where every member’s ideas and | ||
| contributions are valued. We aim to work efficiently and harmoniously by balancing | ||
| creativity and critical thinking, supporting one another to achieve our shared goals | ||
| while maintaining a culture of accountability and care. | ||
|
|
||
| ## Meet the team | ||
|
|
||
| <!-- markdownlint-disable MD033 --> | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th></th> | ||
| <th><strong>Name</strong></th> | ||
| <th><strong>GitHub</strong></th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <td> | ||
| <img src="https://avatars.githubusercontent.com/u/189562848?v=4" | ||
| alt="Ana Isabel Murillo" width="50"> | ||
| </td> | ||
| <td>Ana Isabel Murillo</td> | ||
| <td><a href="https://github.com/AnaiMurillo">AnaiMurillo</a></td> | ||
| </tr><tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/174089681?v=4" | ||
| alt="Mr-Glucose" width="50"></td> | ||
| <td>Arthur Dorvil</td> | ||
| <td><a href="https://github.com/Mr-Glucose">Mr-Glucose</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/188538629?v=4" | ||
| alt="Chrismy Augustin" width="50"></td> | ||
| <td>Chrismy Augustin</td> | ||
| <td><a href="https://github.com/likechrisss">likechrisss</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/92646899?v=4" | ||
| alt="Cliforde Exael" width="50"></td> | ||
| <td>Cliforde Exael</td> | ||
| <td><a href="https://github.com/Lastrophysicien">Lastrophysicien</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/115899276?v=4" | ||
| alt="Hector Colmenares" width="50"></td> | ||
| <td>Hector Colmenares</td> | ||
| <td><a href="https://github.com/hectordacb">hectordacb</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/189242306?v=4" | ||
| alt="Jeampierr Jiménez" width="50"></td> | ||
| <td>Jeampierr Jiménez</td> | ||
| <td><a href="https://github.com/Jeampierr1102">Jeampierr1102</a></td> | ||
| </tr> | ||
| <td> | ||
| <img src="https://avatars.githubusercontent.com/u/189233851?v=4" | ||
| alt="Pierre Kenley MERVIL" width="50"> | ||
| </td> | ||
| <td>Pierre Kenley MERVIL</td> | ||
| <td><a href="https://github.com/MPKenley">MPKenley</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/86928180?v=4" | ||
| alt="Ramon Colmenares" width="50"></td> | ||
| <td>Ramon Colmenares</td> | ||
| <td><a href="https://github.com/RamonColmenares">RamonColmenares</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td><img src="https://avatars.githubusercontent.com/u/189634607?v=4" | ||
| alt="Semira Tesfai" width="50"></td> | ||
| <td>Semira Tesfai</td> | ||
| <td><a href="https://github.com/SEMIRATESFAI">SEMIRATESFAI</a></td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <!-- markdownlint-enable MD033 --> | ||
|
|
||
| ## Project Progress | ||
|
|
||
| We track our progress using the | ||
| [GitHub Kanban Board](https://github.com/orgs/MIT-Emerging-Talent/projects/104). | ||
| Here's a quick look at our board in action: | ||
|
|
||
|  | ||
|
|
||
| ## Technologies & Tools 🛠️ | ||
|
|
||
| - **Languages:** Python | ||
| - **Frameworks/Libraries:** Unittest | ||
| - **Documentation:** Markdown | ||
| - **Version Control:** Git, GitHub | ||
| - **Other Tools:** VS Code | ||
|
|
||
| ## Getting Started 🚀 | ||
|
|
||
| Before cloning this repository, make sure you have Git | ||
| installed and are signed into your GitHub account. | ||
|
|
||
| ### Clone the Repository | ||
|
|
||
| 1. Open your terminal (Command Prompt, Git Bash, or terminal of choice). | ||
|
|
||
| 2. Clone the repository using either SSH or HTTPS. | ||
|
|
||
| **Using SSH**: | ||
|
|
||
| ```bash | ||
| git clone [email protected]:MIT-Emerging-Talent/ET6-foundations-group-04.git | ||
| ``` | ||
|
|
||
| ### Run the Tests | ||
|
|
||
| 1. Open your terminal (Command Prompt, Git Bash, or terminal of choice). | ||
|
|
||
| 2. Navigate to the project directory: | ||
|
|
||
| ```bash | ||
| cd ET6-foundations-group-04 | ||
| ``` | ||
|
|
||
| 3. Run the tests using: | ||
|
|
||
| ```bash | ||
| python -m unittest | ||
| ``` | ||
|
|
||
| ## Contributing | ||
|
|
||
| Please refer to our [Contributing Guide](CONTRIBUTING.md) for information | ||
| on how to contribute to this project. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,40 @@ | ||
| <!-- this template is for inspiration, feel free to change it however you like! --> | ||
|
|
||
| # Constraints | ||
|
|
||
| Some boundaries around our project. | ||
|
|
||
| ## External | ||
|
|
||
| <!-- | ||
| constraints coming from the outside that your team has no control over: | ||
| - project deadlines | ||
| - number of unit tests required to pass a code review | ||
| - technologies (sometimes a client will tell you what to use) | ||
| - power or connectivity | ||
| - ... | ||
| --> | ||
| - **Project Deadlines**: The project must be completed and delivered by | ||
| **January 8th**. Extensions are not an option. | ||
| - **Technology Requirements**: We are required to use specific technologies such | ||
| as VS Code, Python, and GitHub. | ||
| - **Testing Standards**: All code must pass a minimum of 90% unit test coverage | ||
| and meet quality metrics defined by MIT Emerging Talent Foundations Track instructors. | ||
| - **Connectivity**: Some team members might face intermittent internet connectivity. | ||
|
|
||
| ## Internal: Involuntary | ||
|
|
||
| <!-- | ||
| constraints that come from within your team, and you have no control over: | ||
| - each of your individual skill levels | ||
| - amount of time available to work on the project | ||
| --> | ||
| - **Skill Levels**: The team includes members with varying levels of expertise, | ||
| with some being beginners who are still learning the required tools and technologies. | ||
| - **Time Availability**: Team members have varying schedules and commitments, | ||
| which can impact how much time each person can contribute. | ||
| - **Learning Curve**: Beginners may require additional time to learn new tools, | ||
| frameworks, or workflows, potentially slowing progress. | ||
|
|
||
| ## Internal: Voluntary | ||
|
|
||
| <!-- | ||
| constraints that your team decided on to help scope the project. they may include: | ||
| - coding style & conventions | ||
| - agree on a code review checklist for the project repository | ||
| - the number of hours you want to spend working | ||
| - only using the colors black and white | ||
| --> | ||
| - **Independent Work**: Each team member works independently on their assigned | ||
| tasks but can seek advice or guidance from others as needed. | ||
| - **Coding Standards**: The team has agreed to follow a consistent coding style | ||
| guide to maintain quality and readability. | ||
| - **Code Reviews**: All pull requests will be reviewed by at least two other | ||
| team members to ensure quality and foster knowledge sharing. | ||
| - **Collaboration Tools**: Communication tools like Slack will be used for quick | ||
| questions and advice, while GitHub Discussions and Issues will handle more | ||
| structured feedback. | ||
| - **Documentation**: Clear and beginner-friendly comments and documentation are | ||
| mandatory for all code to make it accessible to everyone on the team. | ||
| - **Scope Management**: To ensure progress, the project scope is limited to core | ||
| features. | ||
| - **Flexibility**: Pioneers United encourages flexibility, allowing members to | ||
| ask for help or advice at any point without hesitation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # **Challenge: Use of Operators** | ||
|
|
||
| ## **Instructions:** | ||
|
|
||
| 1. Create a loop to go through each element in the list called `lista_de_elementos`. | ||
| 2. Check the type of each element: | ||
| - If the element is a number (integer or float), check if it is below the | ||
| defined threshold (`umbral`). | ||
| - Print **"Approved"** if the value is below the threshold. | ||
| - Print **"Rejected"** otherwise. | ||
| - If the element is a string (`str`), skip the comparison with the threshold. | ||
| 3. Implement two counters: | ||
| - One to count the number of approved elements. | ||
| - One to count the number of rejected elements. | ||
| 4. Count the elements that are of type string (`str`) and print the total | ||
| at the end of the loop. | ||
| 5. Print the total of approved and rejected elements at the end of the code. | ||
|
|
||
| ## **Initial Parameters:** | ||
|
|
||
| ```python | ||
| threshold = -10 | ||
| elements_list = [ | ||
| 10, 3.14, "7", -5, "2.718", 42, "Python", -8.9, "Hello", 100.5, | ||
| "World", -15, "GPT-3", 5.5, "AI", -20, "2023", 123, "OpenAI", | ||
| -2.5, "Example" | ||
| ] | ||
|
|
||
| # Development of the main code loop. | ||
| # In this space, you must write the code following the | ||
| # instructions from the previous cell. | ||
|
|
||
|
|
||
|
|
||
| print("Total approved: ", approved) | ||
| print("Total rejected: ", rejected) | ||
| print("Total strings: ", string_count) | ||
|
|
||
| ``` | ||
|
|
||
| ### **Expected Output:** | ||
|
|
||
| At the end of the loop, the program should print: | ||
|
|
||
| - The total number of approved elements. | ||
| - The total number of rejected elements. | ||
| - The total number of strings (`str`). | ||
|
|
||
| ### Helpful Links | ||
|
|
||
| 1. **`for` loop in Python** | ||
| Documentación oficial sobre cómo usar los bucles `for` en Python: | ||
| [for statement - Python Docs](https://docs.python.org/3/reference/simple_stmts.html#for) | ||
|
|
||
| 2. **`if` statement in Python** | ||
| Documentación oficial sobre cómo usar las sentencias `if` en Python: | ||
| [if statement - Python Docs](https://docs.python.org/3/reference/compound_stmts.html#if) | ||
|
|
||
| [Github issue](https://github.com/MIT-Emerging-Talent/ET6-foundations-group-04/issues/04) |
Empty file.
Oops, something went wrong.